Fixes a cursor offset mistake for Material on iOS #27851
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xster
reviewed
Feb 12, 2019
Member
xster
left a comment
xster
left a comment
There was a problem hiding this comment.
Ok to do in a separate PR but we should have golden tests for the cursor on Material TextField on Android and iOS and for CupertinoTextField
xster
reviewed
Feb 13, 2019
Member
|
LGTM modulo one more test |
zoechi
added
a: text input
HansMuller
reviewed
Feb 13, 2019
Member
|
LGTM. We can do this and add the test later to unblock the roll. |
HansMuller
approved these changes
Feb 13, 2019
Contributor
HansMuller
left a comment
HansMuller
left a comment
There was a problem hiding this comment.
LGTM (please undo the reformatting)
Contributor
I want to make sure this isn't dropped - we need pre-commit golden image tests that would have caught this. |
9 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #27626.