Switch flutter_tools from script to app-jit snapshot.#27749
Merged
Conversation
zoechi
added
the
tool
Contributor
Author
|
These tests do not fail locally, investigating as a potential issue with the cirrus env |
jonahwilliams
requested review from
dnfield and
yjbanov
and removed request for
dnfield
March 15, 2019 14:29
yjbanov
approved these changes
Mar 15, 2019
| path.join(flutterRoot, 'packages', 'flutter_tools'), | ||
| flutterRoot, | ||
| enableFlutterToolAsserts: true, | ||
| enableFlutterToolAsserts: false, // required to use app-jit tool snapshots. |
Contributor
There was a problem hiding this comment.
Would it be possible to ever flip this flag to true? If not, maybe remove it?
| import '../runner/flutter_command.dart'; | ||
|
|
||
| // This command is run when generating the app-jit snapshot for the tool, so it cannot access the Cache | ||
| // or any artifacts that haven't been downloaded yet. |
|
|
||
| // This command is run when generating the app-jit snapshot for the tool, so it cannot access the Cache | ||
| // or any artifacts that haven't been downloaded yet. | ||
| class TrainingCommand extends FlutterCommand { |
Contributor
There was a problem hiding this comment.
There's not a lot of training here :)
Contributor
|
|
added 2 commits
March 15, 2019 15:04
Contributor
Author
|
The tool_tests-linux has actually passed, submitting |
Contributor
Author
|
This had a small, but measurable speedup on flutter test - yay!
|
Contributor
|
🎆 |
Contributor
|
Let's update the baseline! |
dart-bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Mar 22, 2019
This reverts move to appjit for flutter tools (flutter/flutter#27749) that is in the range of the changes that broke `pub run build_runner test` Change-Id: Ia1c1e66031fb7976faf75cf4a9bf95bac3a450a0 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/97640 Reviewed-by: Alexander Aprelev <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small startup improvement to tools time as measured on a mac:
script:
app-jit
Also added a training command where we could attempt to exercise more of the tool to get better training. Requires disabling asserts for certain tools tests