-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Roll engine to 05fee4eeee0ff6b219b1fcc394371e5f6963cc46 #26713
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbracken
reviewed
Jan 18, 2019
chinmaygarde
approved these changes
Jan 22, 2019
kangwang1988
pushed a commit
to XianyuTech/flutter
that referenced
this pull request
Feb 12, 2019
* move flutter_assets to App.framework * Roll engine to 05fee4e 05fee4e Update default flutter_assets path for iOS embedding (flutter/engine#7518) 02205db Roll src/third_party/skia 5d052dac3ac1..02738a86e5fd (4 commits) (flutter/engine#7541) af907c0 Roll src/third_party/skia 5c7a3ac0e214..5d052dac3ac1 (7 commits) (flutter/engine#7540) dde2866 IWYU to get SkFontMetrics (flutter/engine#7539)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
a: assets
Packaging, accessing, or using assets
platform-ios
iOS applications specifically
tool
Affects the "flutter" command-line tool. See also t: labels.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relands #26675
Manual roll of engine required here because we've changed the default location of flutter_assets
05fee4e Update default flutter_assets path for iOS embedding (flutter/engine#7518)
02205db Roll src/third_party/skia 5d052dac3ac1..02738a86e5fd (4 commits) (flutter/engine#7541)
af907c0 Roll src/third_party/skia 5c7a3ac0e214..5d052dac3ac1 (7 commits) (flutter/engine#7540)
dde2866 IWYU to get SkFontMetrics (flutter/engine#7539)
/cc @chinmaygarde @xster