Skip to content

Conversation

@dnfield
Copy link
Contributor

@dnfield dnfield commented Jan 17, 2019

Relands #26675

Manual roll of engine required here because we've changed the default location of flutter_assets

05fee4e Update default flutter_assets path for iOS embedding (flutter/engine#7518)
02205db Roll src/third_party/skia 5d052dac3ac1..02738a86e5fd (4 commits) (flutter/engine#7541)
af907c0 Roll src/third_party/skia 5c7a3ac0e214..5d052dac3ac1 (7 commits) (flutter/engine#7540)
dde2866 IWYU to get SkFontMetrics (flutter/engine#7539)

/cc @chinmaygarde @xster

@zoechi zoechi added platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels. a: assets Packaging, accessing, or using assets labels Jan 17, 2019
@dnfield dnfield requested review from xster and removed request for xster January 18, 2019 06:31
@dnfield dnfield changed the title [WIP] Flutter assets ios Roll engine to 05fee4eeee0ff6b219b1fcc394371e5f6963cc46 Jan 21, 2019
@dnfield dnfield requested review from chinmaygarde and xster January 22, 2019 04:13
@dnfield dnfield merged commit 386f346 into flutter:master Jan 22, 2019
@dnfield dnfield deleted the flutter_assets_ios branch January 22, 2019 05:23
kangwang1988 pushed a commit to XianyuTech/flutter that referenced this pull request Feb 12, 2019
* move flutter_assets to App.framework

* Roll engine to 05fee4e

05fee4e Update default flutter_assets path for iOS embedding (flutter/engine#7518)
02205db Roll src/third_party/skia 5d052dac3ac1..02738a86e5fd (4 commits) (flutter/engine#7541)
af907c0 Roll src/third_party/skia 5c7a3ac0e214..5d052dac3ac1 (7 commits) (flutter/engine#7540)
dde2866 IWYU to get SkFontMetrics (flutter/engine#7539)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

a: assets Packaging, accessing, or using assets platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants