Skip to content

Revert "Move flutter_assets to App.framework (#26630)" #26675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dnfield merged 1 commit into from
Jan 17, 2019
Merged

Revert "Move flutter_assets to App.framework (#26630)" #26675

dnfield merged 1 commit into from
Jan 17, 2019

Conversation

@dnfield
Copy link
Contributor

@dnfield dnfield commented Jan 16, 2019 •
edited
Loading

This reverts commit d8db70a (#26630).

Appears to have broken device lab. Will investigate.

TBR @chinmaygarde or @xster

@xster xster mentioned this pull request Jan 17, 2019
Closed
@dnfield dnfield merged commit 4c99958 into flutter:master Jan 17, 2019
@zoechi zoechi added tool Affects the "flutter" command-line tool. See also t: labels. framework flutter/packages/flutter repository. See also f: labels. a: existing-apps Integration with existing apps via the add-to-app flow t: xcode "xcodebuild" on iOS and general Xcode project management and removed framework flutter/packages/flutter repository. See also f: labels. labels Jan 17, 2019
@dnfield dnfield mentioned this pull request Jan 17, 2019
Merged
kangwang1988 pushed a commit to XianyuTech/flutter that referenced this pull request Feb 12, 2019
@dnfield @kangwang1988
Revert "Move flutter_assets to App.framework (flutter#26630)" (flutte…
5db336d 
…r#26675)

This reverts commit d8db70a.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@chinmaygarde chinmaygarde chinmaygarde approved these changes

Assignees

No one assigned

Labels

a: existing-apps Integration with existing apps via the add-to-app flow t: xcode "xcodebuild" on iOS and general Xcode project management tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dnfield @chinmaygarde @zoechi @googlebot