Wrap lines at 80 characters #26285
Merged
Wrap lines at 80 characters #26285
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zoechi
added
the
c: contributor-productivity
Contributor
|
LGTM, but will this affect the license compression that we use in the engine? It relies on licenses having common segments of text to make the binary size smaller. Check with @goderbauer.
|
gspencergoog
approved these changes
Jan 10, 2019
mit-mit
added a commit
to flutter/engine
that referenced
this pull request
Jan 10, 2019
Synchronize with flutter/flutter#26285
Member
Author
|
Sent a PR to synchronize flutter/engine |
Member
|
Can you build a flutter apk and check that this change doesn't increase the size of the combined LICENSE file inside? |
Member
Author
|
Change in flutter/engine landed. I don't see any size difference when |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wrap lines consistently with other files