Pin the goldens repo to a specific commit in the android_views test. #25678
Conversation
|
What was the issue we were trying to solve? Was it that tests were slow because await goldensClient.prepare(); should have checked some cache? Otherwise, the next time some maintainer changes a golden, they'd have to change goldens.version and this pubspec too? Either way LGTM since I don't know much about this test. You can decide. |
|
It was actually your idea 😄 (#20959). It's just simpler this way, e.g in #23900 (comment) it created confusion when I pointed someone to run the android_views app as a diagnostic step. |
|
As for updating the pinned commit, what this test is using off the goldens repository is a recorded touch sequence. It is the only things of goldens used by this test and the only test that uses the touch sequence recording. |
|
Ah I see. The pubspec tries to get that directory directly without being wrapped by anything from flutter_tools that makes sure to clone it first. Makes sense. LGTM |
* flt_master: (143 commits) Roll engine 215ca15..d8c5ec0 (12 commits) (flutter#25728) Provide some more locations for the FAB. (flutter#24736) Undeprecated BigInteger support, but document what it actually does. (flutter#24511) ClipPath.shape and related fixes (flutter#24816) Handle errors in `compute()` by propagating them to the Future. (flutter#24848) Fix merge conflict. (flutter#25718) Some minor tweaks to InputDecoration (mainly docs). (flutter#24643) Expose font fallback API in TextStyle, Roll engine 54a3577..215ca15 (8 commits) (flutter#25585) Updated Shrine demo (flutter#25674) Pin the goldens repo to a specific commit in the android_views test. (flutter#25678) Friendlier flags for Dart compilation training. (flutter#25645) Revert dependency upgrade to see if it helps with build times and APK size (flutter#25642) Depend on the goldens repo through git. (flutter#25479) no period after an alone link in see also section (flutter#25604) Update links for China help (flutter#25238) Roll engine 6a90418..54a3577 (23 commits) (flutter#25649) Roll engine e859296..6a90418 (4 commits) (flutter#25643) Adding support for android app bundle - Issue flutter#17829 (flutter#24440) Revert "[O] Remove many timeouts. (flutter#23531)" (flutter#25646) [O] Remove many timeouts. (flutter#23531) ...
4 participants
No description provided.