Add param "extendedBody" for Scaffold (#17555) - #25654

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.

What to do if you already signed the CLA

Individual signers

• It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

• Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
• The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
• The email used to register you as an authorized contributor must also be attached to your GitHub account.

I signed it!

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

CLAs look good, thanks!

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

CLAs look good, thanks!

Any update on this?

Looking now. Sorry about the delay.

Generally speaking:

• The PR's description should:
  -- Describe what's being changed and why.
  -- List the existing issues that the PR fixes.
  -- If the PR introduces visual changes, before and after screenshots should be included. If possible, it's helpful to crop full-screen screenshots to highlight the changes.
• The changes introduced by the PR should defend against regressions with tests.
• If the changes fix an issue, then a regression test that's specific to the issue should be included.

This PR looks like it will fix #17555

If extendedBody is true, should the body resize when the keyboard is displayed, i.e. when the MediaQuery's viewInset.bottom > 0? Presumably it should unless Scaffold.resizeToAvoidBottomInset is true?

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

CLAs look good, thanks!

@HansMuller I edited Issue and added tests

@HansMuller I edited the issue and refactored the tests.

Any update on this?

So I was thinking of using this in my own app, but there's a huge problem with it, as far as I can tell: you have to add padding to the bottom of your list (or whatever is in your body), but there's really no way to know how much padding to add.

What we really need to do is find a way to put the padding that we add at the bottom into the MediaQuery for the body.

In my app I worked around this like this:

                  body: LayoutBuilder(
                    builder: (BuildContext context, BoxConstraints constraints) {
                      const double bottomPadding = 50.0;
                      final double height = constraints.maxHeight + bottomPadding;
                      final MediaQueryData metrics = MediaQuery.of(context);
                      return OverflowBox(
			minWidth: constraints.maxWidth,
                        maxWidth: constraints.maxWidth,
                        minHeight: height,
                        maxHeight: height,
                        alignment: Alignment.topCenter,
                        child: MediaQuery(
                          data: metrics.copyWith(padding: metrics.padding.copyWith(bottom: bottomPadding)),
                          child: TabBarView(
                            children: pages,
                          ),
                        ),
                      );
                    },
	          ),

@Hixie thanks, I understood. I'll try to do

Is this going to be merged to Flutter soon? Personally I think it gives meaning to notched fab and bnb

@aytunch sorry, I do not have much time to work on PR. I will try to continue next week.

@IKatsuba I'm working on a version of this PR that generates the appropriate MediaQuery to per #25654 (comment). It's a bit tricky. I hope to have something up for review today.

@HansMuller sorry guys. Trying to find time in the next couple of days.

I've moved this PR to #27973, so I'm going to close this one.

@IKatsuba - thanks for looking into this issue and writing a fix! I hope to land #27973 tomorrow or early next week.