Skip to content

Friendlier flags for Dart compilation training. #25645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sbaranov merged 1 commit into from
Dec 21, 2018
Merged

Friendlier flags for Dart compilation training. #25645

sbaranov merged 1 commit into from
Dec 21, 2018

Conversation

@sbaranov
Copy link
Contributor

@sbaranov sbaranov commented Dec 21, 2018 •
edited
Loading

  • Renamed --save-compilation-trace to flutter run --train
  • Renamed --precompile=[file] to --compilation-trace-file=[file]
  • In dynamic mode, made JIT snapshot the default (not kernel file)

@sbaranov
Friendlier flags for Dart compilation training.
cb63543 
* Renamed --save-compilation-trace to flutter run --train.
* Renamed --precompile=<file> to --compilation-trace-file=<file>.
* In dynamic mode, made JIT snapshot the default, instead of kernel file.
@zoechi zoechi added the tool Affects the "flutter" command-line tool. See also t: labels. label Dec 21, 2018
@sbaranov sbaranov requested a review from goderbauer December 21, 2018 19:15
goderbauer
goderbauer approved these changes Dec 21, 2018
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sbaranov sbaranov merged commit 6d6ada1 into flutter:master Dec 21, 2018
@sbaranov sbaranov deleted the niceflags branch December 21, 2018 20:28
kangwang1988 added a commit to XianyuTech/flutter that referenced this pull request Dec 26, 2018
@kangwang1988
Merge branch 'flt_master' into flutter_driver_refactor
5938a7c 
* flt_master: (143 commits)
  Roll engine 215ca15..d8c5ec0 (12 commits) (flutter#25728)
  Provide some more locations for the FAB. (flutter#24736)
  Undeprecated BigInteger support, but document what it actually does. (flutter#24511)
  ClipPath.shape and related fixes (flutter#24816)
  Handle errors in `compute()` by propagating them to the Future. (flutter#24848)
  Fix merge conflict. (flutter#25718)
  Some minor tweaks to InputDecoration (mainly docs). (flutter#24643)
  Expose font fallback API in TextStyle, Roll engine 54a3577..215ca15 (8 commits) (flutter#25585)
  Updated Shrine demo (flutter#25674)
  Pin the goldens repo to a specific commit in the android_views test. (flutter#25678)
  Friendlier flags for Dart compilation training. (flutter#25645)
  Revert dependency upgrade to see if it helps with build times and APK size (flutter#25642)
  Depend on the goldens repo through git. (flutter#25479)
  no period after an alone link in see also section (flutter#25604)
  Update links for China help (flutter#25238)
  Roll engine 6a90418..54a3577 (23 commits) (flutter#25649)
  Roll engine e859296..6a90418 (4 commits) (flutter#25643)
  Adding support for android app bundle - Issue flutter#17829 (flutter#24440)
  Revert "[O] Remove many timeouts. (flutter#23531)" (flutter#25646)
  [O] Remove many timeouts. (flutter#23531)
  ...
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@goderbauer goderbauer goderbauer approved these changes

Assignees

No one assigned

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sbaranov @goderbauer @zoechi @googlebot