Skip to content

Conversation

@a14n
Copy link
Contributor

@a14n a14n commented Dec 20, 2018

This makes all See also sections look the same.

@zoechi zoechi added framework flutter/packages/flutter repository. See also f: labels. d: api docs Issues with https://api.flutter.dev/ labels Dec 20, 2018
@goderbauer
Copy link
Member

I think ideally we want each "see also" point to include a brief description why I may want to also look at the linked content...

@a14n
Copy link
Contributor Author

a14n commented Dec 21, 2018

I think ideally we want each "see also" point to include a brief description why I may want to also look at the linked content...

I agree but it's not really the purpose of this PR ;) FWIW there are 93 occurences of such references without description.

Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@a14n a14n merged commit 19ce65e into flutter:master Dec 21, 2018
@a14n a14n deleted the no-period-link branch December 21, 2018 18:23
kangwang1988 added a commit to XianyuTech/flutter that referenced this pull request Dec 26, 2018
* flt_master: (143 commits)
  Roll engine 215ca15..d8c5ec0 (12 commits) (flutter#25728)
  Provide some more locations for the FAB. (flutter#24736)
  Undeprecated BigInteger support, but document what it actually does. (flutter#24511)
  ClipPath.shape and related fixes (flutter#24816)
  Handle errors in `compute()` by propagating them to the Future. (flutter#24848)
  Fix merge conflict. (flutter#25718)
  Some minor tweaks to InputDecoration (mainly docs). (flutter#24643)
  Expose font fallback API in TextStyle, Roll engine 54a3577..215ca15 (8 commits) (flutter#25585)
  Updated Shrine demo (flutter#25674)
  Pin the goldens repo to a specific commit in the android_views test. (flutter#25678)
  Friendlier flags for Dart compilation training. (flutter#25645)
  Revert dependency upgrade to see if it helps with build times and APK size (flutter#25642)
  Depend on the goldens repo through git. (flutter#25479)
  no period after an alone link in see also section (flutter#25604)
  Update links for China help (flutter#25238)
  Roll engine 6a90418..54a3577 (23 commits) (flutter#25649)
  Roll engine e859296..6a90418 (4 commits) (flutter#25643)
  Adding support for android app bundle - Issue flutter#17829 (flutter#24440)
  Revert "[O] Remove many timeouts. (flutter#23531)" (flutter#25646)
  [O] Remove many timeouts. (flutter#23531)
  ...
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

d: api docs Issues with https://api.flutter.dev/ framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants