Skip to content

Conversation

@GaryQian
Copy link
Contributor

@GaryQian GaryQian commented Dec 19, 2018

Depends on the changes in flutter/engine#7241. Will require an engine roll.

Adds fontFamilyFallback to TextStyle.

Also rolls engine:

git log --oneline --no-merges 54a3577..215ca15
215ca15 Support user-provided font-fallback. (#7241)
526b4bc Revert "Roll Dart to version e15e8609aa8610f8c432f1caf2ab89358e2fce50 (#7213)" (#7283)
a56467e Roll Dart to version e15e8609aa8610f8c432f1caf2ab89358e2fce50 (#7213)
8532868 Address some comments on previous doc improvement PR (#7274)
367bb9b Roll src/third_party/skia b9c2b6663dfd..9803b8f1d197 (7 commits) (#7280)
37af0cd Roll src/third_party/skia 24c72fe389db..b9c2b6663dfd (1 commits) (#7279)
6b85ed3 Android embedding refactor PR1: JNI Extraction to FlutterJNI.java (#7098)
3969f82 Roll src/third_party/skia bdfe3a3ee9c3..24c72fe389db (1 commits) (#7278)

@zoechi zoechi added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels Dec 20, 2018
@GaryQian GaryQian added the a: typography Text rendering, possibly libtxt label Dec 20, 2018
@GaryQian GaryQian requested a review from cbracken December 20, 2018 18:40
@GaryQian
Copy link
Contributor Author

Tests should pass when the engine is rolled with engine changes (which will land with this).

@Hixie
Copy link
Contributor

Hixie commented Dec 21, 2018

LGTM

@GaryQian GaryQian changed the title Expose font fallback API in TextStyle Expose font fallback API in TextStyle, Roll engine 54a3577c0139..215ca1560088 (8 commits) Dec 21, 2018
@GaryQian GaryQian merged commit 2e2f19d into flutter:master Dec 22, 2018
kangwang1988 added a commit to XianyuTech/flutter that referenced this pull request Dec 26, 2018
* flt_master: (143 commits)
  Roll engine 215ca15..d8c5ec0 (12 commits) (flutter#25728)
  Provide some more locations for the FAB. (flutter#24736)
  Undeprecated BigInteger support, but document what it actually does. (flutter#24511)
  ClipPath.shape and related fixes (flutter#24816)
  Handle errors in `compute()` by propagating them to the Future. (flutter#24848)
  Fix merge conflict. (flutter#25718)
  Some minor tweaks to InputDecoration (mainly docs). (flutter#24643)
  Expose font fallback API in TextStyle, Roll engine 54a3577..215ca15 (8 commits) (flutter#25585)
  Updated Shrine demo (flutter#25674)
  Pin the goldens repo to a specific commit in the android_views test. (flutter#25678)
  Friendlier flags for Dart compilation training. (flutter#25645)
  Revert dependency upgrade to see if it helps with build times and APK size (flutter#25642)
  Depend on the goldens repo through git. (flutter#25479)
  no period after an alone link in see also section (flutter#25604)
  Update links for China help (flutter#25238)
  Roll engine 6a90418..54a3577 (23 commits) (flutter#25649)
  Roll engine e859296..6a90418 (4 commits) (flutter#25643)
  Adding support for android app bundle - Issue flutter#17829 (flutter#24440)
  Revert "[O] Remove many timeouts. (flutter#23531)" (flutter#25646)
  [O] Remove many timeouts. (flutter#23531)
  ...
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

a: typography Text rendering, possibly libtxt f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants