Skip to content

switching from hours to minutes when selecting or dragging hour #24677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sdolski wants to merge 1 commit into from
Closed

switching from hours to minutes when selecting or dragging hour #24677

sdolski wants to merge 1 commit into from

Conversation

@sdolski
Copy link

@sdolski sdolski commented Nov 23, 2018 •
edited by HansMuller
Loading

Fixes #17276
Fixes #29600

Applied pull request tjunxiang92#1 on flutter master and fixed behaviour when selecting an hour.

@estevez-dev, @SankaCoffee could you please review?

P.S. created a new pull request because @tjunxiang92 does not have a CLA.

@zoechi zoechi added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. f: date/time picker Date or time picker widgets labels Nov 28, 2018
@sdolski
Copy link
Author

sdolski commented Jan 15, 2019 •
edited
Loading

@estevez-dev Any timetable for merging this into the master branch?

@HansMuller
Copy link
Contributor

HansMuller commented Feb 13, 2019

Thank you for this contribution and please accept my apologies for taking so long to get to it.

We do plan on making some significant changes to the appearance of the date and time pickers to bring them in line with the latest material guidelines, accessibility guidelines, and the native Android versions.
The change proposed here will be part of that date/time picker overhaul.

This change, like visual updates we're planning, will be backwards incompatible for tests that depend on the current behavior. Best to make all of the changes in one PR, so that downstream tests etc only have to update once.

So I'm afraid I'm going to put this change off a little longer

@HansMuller HansMuller mentioned this pull request Mar 19, 2019
Closed
@darrenaustin darrenaustin mentioned this pull request Apr 24, 2019
Merged
9 tasks
darrenaustin added a commit that referenced this pull request Apr 25, 2019
@darrenaustin
TimePicker moves to minute mode after hour selection (#31566)
0aec08c 
Adds a feature of the native Android Time Picker to our Material Time Picker. When the user selects an hour, it automatically switches to minute mode.

This is a merging of two pull requests:

Code changes from @sdolski #24677
Tests from @lucaslcode #29876

Thanks to both of you for your contributions!
@darrenaustin
Copy link
Contributor

darrenaustin commented Apr 25, 2019

Nice fix. Given that this needed to be resolved with current changes and we need tests for this, I went ahead and combined your PR with the tests from @lucaslcode #29876 and landed that in #31566. Thanks for your work on this.

@darrenaustin darrenaustin mentioned this pull request Apr 25, 2019
Closed
10 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@estevez-dev estevez-dev estevez-dev approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

f: date/time picker Date or time picker widgets f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

6 participants

@sdolski @HansMuller @darrenaustin @estevez-dev @zoechi @googlebot