[H] Undeprecate BigInteger support, but document what it actually does. #24511
Conversation
Hixie
changed the title
|
See also flutter/engine#6903 |
|
cc @amirh |
There was a problem hiding this comment.
Are we recommending to use it for persistent storage (or are we even ok with it?).
Just thinking that if not we probably shouldn't make any commitment of forward compatibility here...
There was a problem hiding this comment.
Doesn't matter what commitment we make. People will use it that way anyway.
There was a problem hiding this comment.
Do you have some historical context as for whether we can just deprecate it? (the comment on the decoder for this mentions we are planning to deprecate it)
I just find it a little weird to have us specify the format, keep a decoder implementation but say if you want to encode subclass and implement exactly this format...
There was a problem hiding this comment.
Coming back here after seeing the readValueOfType change which is backwards incompatible anyways... why not just drop support for this type?
There was a problem hiding this comment.
We said we'd remove it a year ago. We didn't. We missed the boat on deprecation. This is just an attempt to rescue a clean API out of the ashes that remain.
zoechi
added
the
framework
There was a problem hiding this comment.
i need to update this now that we've removed the sending code from ObjectiveC.
Also, some code cleanup.
|
Fixed docs, will land on green. |
* flt_master: (143 commits) Roll engine 215ca15..d8c5ec0 (12 commits) (flutter#25728) Provide some more locations for the FAB. (flutter#24736) Undeprecated BigInteger support, but document what it actually does. (flutter#24511) ClipPath.shape and related fixes (flutter#24816) Handle errors in `compute()` by propagating them to the Future. (flutter#24848) Fix merge conflict. (flutter#25718) Some minor tweaks to InputDecoration (mainly docs). (flutter#24643) Expose font fallback API in TextStyle, Roll engine 54a3577..215ca15 (8 commits) (flutter#25585) Updated Shrine demo (flutter#25674) Pin the goldens repo to a specific commit in the android_views test. (flutter#25678) Friendlier flags for Dart compilation training. (flutter#25645) Revert dependency upgrade to see if it helps with build times and APK size (flutter#25642) Depend on the goldens repo through git. (flutter#25479) no period after an alone link in see also section (flutter#25604) Update links for China help (flutter#25238) Roll engine 6a90418..54a3577 (23 commits) (flutter#25649) Roll engine e859296..6a90418 (4 commits) (flutter#25643) Adding support for android app bundle - Issue flutter#17829 (flutter#24440) Revert "[O] Remove many timeouts. (flutter#23531)" (flutter#25646) [O] Remove many timeouts. (flutter#23531) ...
4 participants
Also, some code cleanup.