[O] Fix a race condition in vmservice_test.dart #23835
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
Hixie
changed the title
aam
approved these changes
Nov 1, 2018
Contributor
|
Tests are failing |
Contributor
Author
|
Oops, merge error. Thanks. Will land on green. |
Hixie
force-pushed
the
vmservice
branch
3 times, most recently
from
192e060 to
bbe77d6
Compare
Contributor
|
Can we land this to try to fix the build? Tool test linux is failing and this is one possible reason why. |
Member
I don't think @Hixie will object if you land this for him. |
Contributor
|
If you think it'll fix the build, then it makes sense to merge on red. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19273