-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Roll engine 162b2e98c036..a1d7cad70c81 (10 commits) #23646
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
engine-flutter-autoroll
merged 1 commit into
flutter:master
from
engine-flutter-autoroll:roll_branch
Oct 28, 2018
Merged
Roll engine 162b2e98c036..a1d7cad70c81 (10 commits) #23646
engine-flutter-autoroll
merged 1 commit into
flutter:master
from
engine-flutter-autoroll:roll_branch
Oct 28, 2018
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter/engine@162b2e9...a1d7cad git log 162b2e9..a1d7cad --no-merges --oneline a1d7cad Fix inconsistent include syntax (flutter/engine#6680) 236661c Roll src/third_party/skia 3b79aa3a5ad0..b53f1f46982d (13 commits) (flutter/engine#6679) c4f5061 Roll buildroot to pick up Mac toolchain updates. (flutter/engine#6678) ba8f6aa Handle Windows headers defining ERROR to 0 in log levels. (flutter/engine#6677) 505d2a9 Roll buildroot to pick up updates to custom toolchains. (flutter/engine#6674) 6c2a0b3 Undefine ERROR in platform_view_layer.cc (flutter/engine#6675) 55e1299 Update FlutterPlugin.h docs, suppress warning for older API (flutter/engine#6672) f797004 Attach and position embedded UIVIews (flutter/engine#6614) df85722 Plumb the iOS PlatformViewsController into flow. (flutter/engine#6603) 2bfb893 iOS Embedding Refactor (flutter/engine#6447) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
1be5f55 to
9313285
Compare
Contributor
Author
Contributor
Author
|
Auto-roller completed checks. About to merge. |
Member
|
This roll caused some benchmarks to regress, see: #23678. |
Contributor
|
This roll is also not passing the platform_interaction_test_ios |
Contributor
|
I think @dnfield has the fix for platform_interaction_test_ios. |
Xavjer
pushed a commit
to Xavjer/flutter
that referenced
this pull request
Nov 1, 2018
flutter/engine@162b2e9...a1d7cad git log 162b2e9..a1d7cad --no-merges --oneline a1d7cad Fix inconsistent include syntax (flutter/engine#6680) 236661c Roll src/third_party/skia 3b79aa3a5ad0..b53f1f46982d (13 commits) (flutter/engine#6679) c4f5061 Roll buildroot to pick up Mac toolchain updates. (flutter/engine#6678) ba8f6aa Handle Windows headers defining ERROR to 0 in log levels. (flutter/engine#6677) 505d2a9 Roll buildroot to pick up updates to custom toolchains. (flutter/engine#6674) 6c2a0b3 Undefine ERROR in platform_view_layer.cc (flutter/engine#6675) 55e1299 Update FlutterPlugin.h docs, suppress warning for older API (flutter/engine#6672) f797004 Attach and position embedded UIVIews (flutter/engine#6614) df85722 Plumb the iOS PlatformViewsController into flow. (flutter/engine#6603) 2bfb893 iOS Embedding Refactor (flutter/engine#6447) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC&flutter#39;d on the roll, and stop the roller if necessary.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
flutter/engine@162b2e9...a1d7cad
git log 162b2e9..a1d7cad --no-merges --oneline
a1d7cad Fix inconsistent include syntax (flutter/engine#6680)
236661c Roll src/third_party/skia 3b79aa3a5ad0..b53f1f46982d (13 commits) (flutter/engine#6679)
c4f5061 Roll buildroot to pick up Mac toolchain updates. (flutter/engine#6678)
ba8f6aa Handle Windows headers defining ERROR to 0 in log levels. (flutter/engine#6677)
505d2a9 Roll buildroot to pick up updates to custom toolchains. (flutter/engine#6674)
6c2a0b3 Undefine ERROR in platform_view_layer.cc (flutter/engine#6675)
55e1299 Update FlutterPlugin.h docs, suppress warning for older API (flutter/engine#6672)
f797004 Attach and position embedded UIVIews (flutter/engine#6614)
df85722 Plumb the iOS PlatformViewsController into flow. (flutter/engine#6603)
2bfb893 iOS Embedding Refactor (flutter/engine#6447)
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.