Roll engine 162b2e98c036..6c2a0b3a6d93 (5 commits) #23612
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter/engine@162b2e9...6c2a0b3 git log 162b2e9..6c2a0b3 --no-merges --oneline 6c2a0b3 Undefine ERROR in platform_view_layer.cc (flutter/engine#6675) 55e1299 Update FlutterPlugin.h docs, suppress warning for older API (flutter/engine#6672) f797004 Attach and position embedded UIVIews (flutter/engine#6614) df85722 Plumb the iOS PlatformViewsController into flow. (flutter/engine#6603) 2bfb893 iOS Embedding Refactor (flutter/engine#6447) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
Contributor
Author
Contributor
Author
|
Auto-roller completed checks. About to merge. |
Contributor
|
Looks like this broke the build. cc @liyuqian |
Contributor
liyuqian
added a commit
that referenced
this pull request
Oct 27, 2018
Xavjer
pushed a commit
to Xavjer/flutter
that referenced
this pull request
Nov 1, 2018
flutter/engine@162b2e9...6c2a0b3 git log 162b2e9..6c2a0b3 --no-merges --oneline 6c2a0b3 Undefine ERROR in platform_view_layer.cc (flutter/engine#6675) 55e1299 Update FlutterPlugin.h docs, suppress warning for older API (flutter/engine#6672) f797004 Attach and position embedded UIVIews (flutter/engine#6614) df85722 Plumb the iOS PlatformViewsController into flow. (flutter/engine#6603) 2bfb893 iOS Embedding Refactor (flutter/engine#6447) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC&flutter#39;d on the roll, and stop the roller if necessary.
Xavjer
pushed a commit
to Xavjer/flutter
that referenced
this pull request
Nov 1, 2018
…utter#23628) This reverts commit 0f34f52. Reverts flutter#23612 as it broke the following two bots: 1. platform_view__start_up 2. platform_interaction_test_ios Merge on red to fix the rope.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
flutter/engine@162b2e9...6c2a0b3
git log 162b2e9..6c2a0b3 --no-merges --oneline
6c2a0b3 Undefine ERROR in platform_view_layer.cc (flutter/engine#6675)
55e1299 Update FlutterPlugin.h docs, suppress warning for older API (flutter/engine#6672)
f797004 Attach and position embedded UIVIews (flutter/engine#6614)
df85722 Plumb the iOS PlatformViewsController into flow. (flutter/engine#6603)
2bfb893 iOS Embedding Refactor (flutter/engine#6447)
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.