Support null locale before locale initialization, Roll engine to cdd592f5be97e824 #23417
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Approved on the closed identical PR: #23375 |
Xavjer
pushed a commit
to Xavjer/flutter
that referenced
this pull request
Oct 24, 2018
(flutter#23417) cdd592f Reland 'Pass null instead of 'none' locale' (flutter#6632) 2cd8920 Roll src/third_party/skia b1a002e850e1..327955b1ba19 (12 commits) (flutter#6631) edfe024 13771 - iOS dictation bug (flutter#6607) cadf440 Roll src/third_party/skia b9998cdceec7..b1a002e850e1 (13 commits) (flutter#6626)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reopened to workaround github breakages. Identical to: #23375
The engine will roll a change that makes uninitialized locales null very soon, but this still works without the change.
Engine Roll:
git log --oneline --no-merges 4c79e42..cdd592f
cdd592f Reland 'Pass null instead of 'none' locale' (#6632)
2cd8920 Roll src/third_party/skia b1a002e850e1..327955b1ba19 (12 commits) (#6631)
edfe024 13771 - iOS dictation bug (#6607)
cadf440 Roll src/third_party/skia b9998cdceec7..b1a002e850e1 (13 commits) (#6626)