Skip to content

Revert "Roll engine 74662ab69523..7e3b41dc7ba6 (6 commits)" #22647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dnfield merged 1 commit into from
Oct 4, 2018
Merged

Revert "Roll engine 74662ab69523..7e3b41dc7ba6 (6 commits)" #22647

dnfield merged 1 commit into from
Oct 4, 2018

Conversation

@dnfield
Copy link
Contributor

@dnfield dnfield commented Oct 4, 2018 •
edited
Loading

Reverts #22639

Breaks on device lab -

stdout:     Building AOT snapshot in release mode (ios-release)...          
stdout:     Unhandled exception:
stdout:     Unsupported operation: Cannot extract a file path from a org-dartlang-sdk URI
stdout:     #0      _SimpleUri.toFilePath (dart:core/uri.dart:4589:7)
stdout:     #1      _writeDepfile (package:vm/frontend_server.dart:655:32)

@dnfield
Copy link
Contributor Author

dnfield commented Oct 4, 2018

Landing TBR @cbracken

@dnfield dnfield merged commit a68b03e into master Oct 4, 2018
@cbracken
Copy link
Member

cbracken commented Oct 4, 2018

lgtm. Thanks for reverting!

@cbracken
Copy link
Member

cbracken commented Oct 4, 2018

@dnfield Have you bisected to an engine commit? If not, we'll get someone on that.

@cbracken cbracken deleted the revert-22639-roll_branch branch October 4, 2018 01:45
@dnfield
Copy link
Contributor Author

dnfield commented Oct 4, 2018

Pretty sure it's flutter/engine#6402

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dnfield @cbracken @googlebot