Roll engine 7e3b41dc7ba6..74e68ff8b108 and update tests #22643
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Gary - something seems off with this (Cirrus can't seem to download the archive), but also I manually helped the engine roller along so you'll now have a conflict. |
Contributor
Author
|
The engine commit is new, so the builders are still building the engine. I can patch it to be compatible with the autoroller. I'll have to rerun the tests in a bit once the builds are complete and available in the cloud. |
GaryQian
changed the title
GaryQian
changed the title
Contributor
|
For future reference, we have a "work in progress" label you can assign to a PR that tells the reviewers that the PR is not yet ready for review, for example, because the engine artifacts are not in place yet. |
yjbanov
approved these changes
Oct 4, 2018
Contributor
|
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git log 7e3b41d..74e68ff --no-merges --oneline
74e68ff Roll src/third_party/skia 7b7805581733..66a973493468 (4 commits) (#6436)
58fbd1f Roll src/third_party/skia 4442e3138927..7b7805581733 (1 commits) (#6435)
83151d9 Roll src/third_party/skia 4dd17156c6e4..4442e3138927 (1 commits) (#6434)
5fe7e37 Roll src/third_party/skia 8841085abeb9..4dd17156c6e4 (1 commits) (#6432)
5340f42 Revert "Use single_root_scheme when compiling platform (#6402)" (#6431)
37fd43d Add deadline_now_delta argument to Engine::NotifyIdle's trace (#6419)
4af077b Roll src/third_party/skia 4504a652c071..8841085abeb9 (1 commits) (#6429)
165f3dd Update //third_party/benchmark dependency to 21f1eb (ToT). (#6427)
34bd0ef Don’t build benchmarking binaries on Windows. (#6428)
ae4db44 Ensure setViewIdResourceName has the correct version guard (#6404)
2c5d0c4 [rapidjson] Fix import statements (#6418)
c2128fc Create a benchmarking target for the shell. (#6420)
30f78af Raise errors on non-zero exits while creating artifacts on the bots. (#6424)
191168c Disable line_height tests on Windows (#6423)
061cc66 Fix ideographic baseline to match spec. (#6422)
74eac1f Roll src/third_party/skia bfa76f20bfcf..4504a652c071 (14 commits) (#6421)
10b4540 Implement ParagraphStyle.line_height and add tests for line_height and baselines. (#6417)