-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Create WidgetTester.ensureVisible(Finder) #22620
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
|
I signed it |
|
CLAs look good, thanks! |
tvolkert
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The distinction between the widget being made visible and the scrollable is a little confusing in the wording here. How about:
/// Given a widget `W` specified by [finder] and a [Scrollable] widget `S` in
/// its ancestry tree, this scrolls `S` so as to make `W` visible.
///
/// Shorthand for `Scrollable.ensureVisible(tester.element(finder))`There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, Yours is simpler. I'll update it.
This is just a shorthand for Scrollable.ensureVisible(tester.element(finder))
Signed-off-by: devkabiir <[email protected]>
tvolkert
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
| /// its ancestry tree, this scrolls `S` so as to make `W` visible. | ||
| /// | ||
| /// Shorthand for `Scrollable.ensureVisible(tester.element(finder))` | ||
| Future<Null> ensureVisible(Finder finder) => Scrollable.ensureVisible(element(finder)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Analysis is failing because Future<void> is the modern replacement for Future<Null>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I was just trying to figure it out.
Future<void> is the modern replacment for Future<Null> Signed-off-by: devkabiir <[email protected]>
…urvives at least two frames (flutter#22620)" (flutter/engine#23044)
…urvives at least two frames (flutter#22620)" (flutter/engine#23044)
…urvives at least two frames (flutter#22620)" (flutter/engine#23044)
…urvives at least two frames (flutter#22620)" (flutter/engine#23044)
This is just a shorthand for
Scrollable.ensureVisible(tester.element(finder))closes #8185