Skip to content

Conversation

@devkabiir
Copy link
Contributor

@devkabiir devkabiir commented Oct 3, 2018

This is just a shorthand for
Scrollable.ensureVisible(tester.element(finder))

closes #8185

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@devkabiir
Copy link
Contributor Author

I signed it

@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes and removed cla: no labels Oct 3, 2018
@devkabiir devkabiir changed the title Create WidgetTester.ensureVisible(Finder) closes (#8185) Create WidgetTester.ensureVisible(Finder) Oct 3, 2018
Copy link
Contributor

@tvolkert tvolkert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The distinction between the widget being made visible and the scrollable is a little confusing in the wording here. How about:

/// Given a widget `W` specified by [finder] and a [Scrollable] widget `S` in
/// its ancestry tree, this scrolls `S` so as to make `W` visible.
///
/// Shorthand for `Scrollable.ensureVisible(tester.element(finder))`

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Yours is simpler. I'll update it.

This is just a shorthand for
Scrollable.ensureVisible(tester.element(finder))
Copy link
Contributor

@tvolkert tvolkert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

/// its ancestry tree, this scrolls `S` so as to make `W` visible.
///
/// Shorthand for `Scrollable.ensureVisible(tester.element(finder))`
Future<Null> ensureVisible(Finder finder) => Scrollable.ensureVisible(element(finder));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Analysis is failing because Future<void> is the modern replacement for Future<Null>

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I was just trying to figure it out.

Future<void> is the modern replacment for Future<Null>

Signed-off-by: devkabiir <[email protected]>
@tvolkert tvolkert merged commit 7fbb5b9 into flutter:master Oct 18, 2018
@devkabiir devkabiir deleted the fix_8185 branch October 18, 2018 19:23
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 14, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 14, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 14, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 15, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create WidgetTester.ensureVisible(Finder)

3 participants