Added ColorScheme dartdoc #22592
Merged
Added ColorScheme dartdoc #22592
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goderbauer
reviewed
Oct 3, 2018
|
|
||
| /// Create a color scheme from a [MaterialColor] swatch. | ||
| /// | ||
| /// This constructor is used by [ThemeData] to create its default \ |
| /// The background color for widgets like [Card]. | ||
| final Color surface; | ||
|
|
||
| /// A color that's clearly legible when drawn on [primary]. |
Member
There was a problem hiding this comment.
Could be worth to link to the a11y guidelines that recommend a contrast ratio of 4.5:1 for the two colors: https://www.w3.org/TR/UNDERSTANDING-WCAG20/visual-audio-contrast-contrast.html
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the build.
TBR: @goderbauer