Skip to content

unnecessary this in field initializers #22522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
a14n merged 1 commit into from
Oct 2, 2018
Merged

unnecessary this in field initializers #22522

a14n merged 1 commit into from
Oct 2, 2018

Conversation

@a14n
Copy link
Contributor

@a14n a14n commented Oct 1, 2018

No description provided.

@a14n
Copy link
Contributor Author

a14n commented Oct 1, 2018

@Hixie

@Hixie
Copy link
Contributor

Hixie commented Oct 2, 2018

LGTM!

@a14n a14n merged commit 5de96bb into flutter:master Oct 2, 2018
@a14n a14n deleted the unnecessary_this-field-initializers branch October 2, 2018 15:15
dnfield added a commit that referenced this pull request Oct 2, 2018
@dnfield
Revert "unnecessary this in field initializers (#22522)"
e26593b 
This reverts commit 5de96bb.
dnfield added a commit that referenced this pull request Oct 2, 2018
@dnfield
Revert "Roll engine f6af1f2..b59c864 (3 commits)" (#22559)
eee5096 
* Revert "unnecessary this in field initializers (#22522)"

This reverts commit 5de96bb.

* Revert "Use unsafePackageSerialization when running tests (#22407)"

This reverts commit 4bd6ad7.

* Revert "Roll engine f6af1f2..b59c864 (3 commits) (#22538)"

This reverts commit 85a4591.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@a14n @Hixie @googlebot