Skip to content

Use unsafePackageSerialization when running tests #22407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jensjoha merged 1 commit into from
Oct 2, 2018
Merged

Use unsafePackageSerialization when running tests #22407

jensjoha merged 1 commit into from
Oct 2, 2018

Conversation

@jensjoha
Copy link
Contributor

@jensjoha jensjoha commented Sep 28, 2018

Running flutter test in flutter/packages/flutter:

Without:
02:32 +3115 ~25: All tests passed!

With:
01:43 +3115 ~25: All tests passed!

@jensjoha jensjoha requested review from aam and mraleph September 28, 2018 07:24
@jensjoha
Copy link
Contributor Author

jensjoha commented Sep 28, 2018

I realize that these numbers are are different than the ones in flutter/engine#6331 --- I'm not sure why --- maybe it's caused by the engine being self-compiled in the flutter/engine comment.

@jensjoha jensjoha mentioned this pull request Sep 28, 2018
Open
@jensjoha jensjoha merged commit 4bd6ad7 into flutter:master Oct 2, 2018
dnfield added a commit that referenced this pull request Oct 2, 2018
@dnfield
Revert "Use unsafePackageSerialization when running tests (#22407)"
b946c89 
This reverts commit 4bd6ad7.
dnfield added a commit that referenced this pull request Oct 2, 2018
@dnfield
Revert "Roll engine f6af1f2..b59c864 (3 commits)" (#22559)
eee5096 
* Revert "unnecessary this in field initializers (#22522)"

This reverts commit 5de96bb.

* Revert "Use unsafePackageSerialization when running tests (#22407)"

This reverts commit 4bd6ad7.

* Revert "Roll engine f6af1f2..b59c864 (3 commits) (#22538)"

This reverts commit 85a4591.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 9, 2021
@jensjoha jensjoha deleted the unsafe-package-serialization-in-test branch August 18, 2022 13:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@aam aam aam approved these changes

@mraleph mraleph Awaiting requested review from mraleph

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jensjoha @aam @googlebot