Skip to content

Conversation

@liyuqian
Copy link
Contributor

@liyuqian liyuqian commented Sep 27, 2018

flutter/engine@38a646e...9d4b80a

git log 38a646e..9d4b80a --no-merges --oneline
9d4b80a Roll src/third_party/skia 17282da3aa94..5767fc042834 (8 commits) (flutter/engine#6348)
ef98dcb Add support for counter timeline traces from the engine. (flutter/engine#6315)
a961e96 Roll buildroot to pick up updated vs toolchain. (flutter/engine#6346)
d6bb599 Fixed IsolateNameServer documentation (flutter/engine#6344)
0c854ac Roll src/third_party/skia bdf1431686c2..17282da3aa94 (4 commits) (flutter/engine#6345)
e394ea1 Roll src/third_party/skia c05302bc84da..bdf1431686c2 (1 commits) (flutter/engine#6343)
bcdfc23 Roll src/third_party/skia 5457141b011e..c05302bc84da (1 commits) (flutter/engine#6342)
a861f37 Pass on the new unsafe-package-serialization option (flutter/engine#6331)
5e77a1e Roll src/third_party/skia bd03b54cb98d..5457141b011e (1 commits) (flutter/engine#6340)
6332db8 Roll src/third_party/skia f18c297cfb74..bd03b54cb98d (1 commits) (flutter/engine#6338)
a08bc52 Roll src/third_party/skia 7ffa40cedbc4..f18c297cfb74 (6 commits) (flutter/engine#6336)
8247ce2 Implement restore functions on Android and iOS (flutter/engine#6322)
2ead5c0 Roll src/third_party/skia 4ef464cd3c2e..7ffa40cedbc4 (10 commits) (flutter/engine#6334)

This roll should succeed according to the previous auto-roll.

@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

flutter/engine@38a646e...9d4b80a

git log 38a646e..9d4b80a --no-merges --oneline
9d4b80a Roll src/third_party/skia 17282da3aa94..5767fc042834 (8 commits) (flutter/engine#6348)
ef98dcb Add support for counter timeline traces from the engine. (flutter/engine#6315)
a961e96 Roll buildroot to pick up updated vs toolchain. (flutter/engine#6346)
d6bb599 Fixed IsolateNameServer documentation (flutter/engine#6344)
0c854ac Roll src/third_party/skia bdf1431686c2..17282da3aa94 (4 commits) (flutter/engine#6345)
e394ea1 Roll src/third_party/skia c05302bc84da..bdf1431686c2 (1 commits) (flutter/engine#6343)
bcdfc23 Roll src/third_party/skia 5457141b011e..c05302bc84da (1 commits) (flutter/engine#6342)
a861f37 Pass on the new unsafe-package-serialization option (flutter/engine#6331)
5e77a1e Roll src/third_party/skia bd03b54cb98d..5457141b011e (1 commits) (flutter/engine#6340)
6332db8 Roll src/third_party/skia f18c297cfb74..bd03b54cb98d (1 commits) (flutter/engine#6338)
a08bc52 Roll src/third_party/skia 7ffa40cedbc4..f18c297cfb74 (6 commits) (flutter/engine#6336)
8247ce2 Implement restore functions on Android and iOS (flutter/engine#6322)
2ead5c0 Roll src/third_party/skia 4ef464cd3c2e..7ffa40cedbc4 (10 commits) (flutter/engine#6334)
@googlebot
Copy link

CLAs look good, thanks!

@liyuqian liyuqian requested review from a-siva and aam September 27, 2018 17:13
@aam
Copy link
Member

aam commented Sep 27, 2018

LGTM and makes sense, but if you land this @a-siva will have to update his #22336.

@liyuqian
Copy link
Contributor Author

@aam : #22336 won't be able to land unless it includes the following fix flutter/engine#6361 for the tool_tests-windows.

@aam
Copy link
Member

aam commented Sep 27, 2018

@aam : #22336 won't be able to land unless it includes the following fix flutter/engine#6361 for the tool_tests-windows.

Cool, thanks for making a fix!

@liyuqian liyuqian merged commit d5b2199 into flutter:master Sep 27, 2018
@liyuqian liyuqian deleted the manual_roll branch September 28, 2018 17:25
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants