Skip to content

Use new run arguments API in flutter_view / Android example. #21975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bkonyi merged 1 commit into from
Oct 10, 2018
Merged

Use new run arguments API in flutter_view / Android example. #21975

bkonyi merged 1 commit into from
Oct 10, 2018

Conversation

@ened
Copy link
Contributor

@ened ened commented Sep 18, 2018 •
edited
Loading

Ensures flutter_view example (Android) does not use deprecated APIs.

@gspencergoog
Copy link
Contributor

gspencergoog commented Oct 10, 2018

@bkonyi, can you review this change? I assume it's in line with your change to add this API.

@gspencergoog gspencergoog requested a review from bkonyi October 10, 2018 16:18
bkonyi
bkonyi approved these changes Oct 10, 2018
View reviewed changes
Copy link
Contributor

@bkonyi bkonyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@bkonyi bkonyi merged commit 9c01c2b into flutter:master Oct 10, 2018
@Hixie
Copy link
Contributor

Hixie commented Oct 11, 2018

How did this have such a good impact on our benchmarks?

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@bkonyi bkonyi bkonyi approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ened @gspencergoog @Hixie @bkonyi @googlebot