Revert "Use Xcode legacy build system for iOS builds (#21901)" #21966
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This caused issues for projects without an Xcode workspace. Almost all Flutter projects in the wild will have a workspace, but this patch needs to add a check to catch any that lack one. This reverts commit 021f472.
Member
Author
|
Landing TBR on red to fix failed iOS tests (complex_layout benchmark). |
hereisderek
added a commit
to hereisderek/flutter
that referenced
this pull request
Sep 18, 2018
…dle-fix * commit 'b01d3a2abc9cd44b3024b1219a9da5f8342939e0': Roll engine dcbc8a8..9e315e6 (3 commits) (flutter#21979) remove unnecessary ignore prefer_const_constructors (flutter#21934) Roll engine to dcbc8a8 Roll engine to ba77529 Revert "Use Xcode legacy build system for iOS builds (flutter#21901)" (flutter#21966) Use Xcode legacy build system for iOS builds (flutter#21901) Remove all "flaky" annotations from devicelab (flutter#21895) Roll engine 1b2a207..b0b19d6 (1 commits) (flutter#21948)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This caused issues for projects without an Xcode workspace. Almost all
Flutter projects in the wild will have a workspace, but this patch needs
to add a check to catch any that lack one.
This reverts commit 021f472.