Skip to content

Conversation

@jonahwilliams
Copy link
Contributor

@jonahwilliams jonahwilliams commented Sep 18, 2018

Check RichText in find.text if the direct parent element is not a Text widget. This allows users to find the text value of RichText without double-counting the RichText widget created by Text.

Fixes #21961

@jonahwilliams jonahwilliams changed the title check RichText in find.text if the direct parent element is not a Text widget Add RichText support to find.text Sep 18, 2018
@yjbanov
Copy link
Contributor

yjbanov commented Sep 18, 2018

This seems like a good change, but it is technically a breaking change because something that findsOneWidget today could now fail. You might want to give a heads up on the relevant mailing lists.

@yjbanov
Copy link
Contributor

yjbanov commented Sep 18, 2018

lgtm

@jonahwilliams jonahwilliams merged commit ff1f8dd into flutter:master Sep 19, 2018
@jonahwilliams jonahwilliams deleted the find_rich_text branch September 19, 2018 17:01
jonahwilliams pushed a commit that referenced this pull request Sep 19, 2018
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support RichText in finders

3 participants