Fix the @macro link in doc #21890
Merged
Fix the @macro link in doc #21890
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Is it possible to add a unit test to make sure that all links in our Dart doc are valid?
Contributor
|
Heh. Well, technically, yes, but right now dartdoc emits so many "warnings" (thousands! many of which are actually errors, IMO), that there's too much noise for it to be useful. |
gspencergoog
approved these changes
Sep 14, 2018
Contributor
|
|
hereisderek
added a commit
to hereisderek/flutter
that referenced
this pull request
Sep 16, 2018
…dle-fix * commit '1ad538e454c77496fbd068b9e8b5f8b61c2f6d96': Fix the @macro link in doc (flutter#21890) Track 90th, 99th percentile instead of missed_frame_build_budget_count (flutter#21754) 24d9460 Roll Dart to bb56d4592f7cde38cdf0a04ad7f40d105af99d11 (flutter#21883) enable lint prefer_generic_function_type_aliases (flutter#21680) Roll engine 7a9b430..60bb5da (2 commits) (flutter#21880) Roll engine ade2d1d..7a9b430 (1 commits) (flutter#21878)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is it possible to add a unit test to make sure that all links in our
Dart doc are valid?