Skip to content

Conversation

@engine-flutter-autoroll
Copy link
Contributor

flutter/engine@1231573...c0e6f6a

git log 1231573..c0e6f6a --no-merges --oneline
c0e6f6a Roll src/third_party/skia 76bba35cbaa4..46a5f6c28a34 (1 commits) (flutter/engine#6244)
49ef4ad Fix a crash when UILaunchStoryboardName is not specified in Info.plist (flutter/engine#6234)
2a433bc Roll src/third_party/skia 34e5e1b387f5..76bba35cbaa4 (2 commits) (flutter/engine#6243)
0c28a09 Roll src/third_party/skia 858f648bdae3..34e5e1b387f5 (8 commits) (flutter/engine#6241)
513f8fb Roll src/third_party/skia 16322637c477..858f648bdae3 (7 commits) (flutter/engine#6240)
9a7d721 Roll src/third_party/skia 44215505623b..16322637c477 (10 commits) (flutter/engine#6238)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

flutter/engine@1231573...c0e6f6a

git log 1231573..c0e6f6a --no-merges --oneline
c0e6f6a Roll src/third_party/skia 76bba35cbaa4..46a5f6c28a34 (1 commits) (flutter/engine#6244)
49ef4ad Fix a crash when UILaunchStoryboardName is not specified in Info.plist (flutter/engine#6234)
2a433bc Roll src/third_party/skia 34e5e1b387f5..76bba35cbaa4 (2 commits) (flutter/engine#6243)
0c28a09 Roll src/third_party/skia 858f648bdae3..34e5e1b387f5 (8 commits) (flutter/engine#6241)
513f8fb Roll src/third_party/skia 16322637c477..858f648bdae3 (7 commits) (flutter/engine#6240)
9a7d721 Roll src/third_party/skia 44215505623b..16322637c477 (10 commits) (flutter/engine#6238)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
@engine-flutter-autoroll
Copy link
Contributor Author

@goderbauer
Copy link
Member

Closing because it is stuck: cirrus has completed all checks successfully, but github's new checks feature still shows one check as pending.

@goderbauer goderbauer closed this Sep 13, 2018
@goderbauer goderbauer reopened this Sep 13, 2018
@goderbauer goderbauer closed this Sep 13, 2018
@goderbauer
Copy link
Member

@fkorotkov This PR is also having trouble with github's new Checks thing: Cirrus has completed the task codelabs-build-test successfully, but github believes it's still pending.

@goderbauer
Copy link
Member

goderbauer commented Sep 13, 2018

Actually, since this seems to be a bug with github and/or cirrus I am going to submit this one manually. On Cirrus all checks completed successfully even though github doesn't reflect that.

@goderbauer goderbauer reopened this Sep 13, 2018
@goderbauer goderbauer merged commit 3c43b0a into flutter:master Sep 13, 2018
@fkorotkov
Copy link
Contributor

@goderbauer, sorry about that. I've been working with GitHub engineers on fixing these issues. Provided all the logs to them so hopefully they'll fix "seems like a race condition" issues.

@engine-flutter-autoroll
Copy link
Contributor Author

Commit queue failed; closing this roll.

@rmistry
Copy link

rmistry commented Dec 6, 2018

@goderbauer, sorry about that. I've been working with GitHub engineers on fixing these issues. Provided all the logs to them so hopefully they'll fix "seems like a race condition" issues.

@fkorotkov
I have been seeing this happening more frequently on the other github roller. Was there a bug filed to Github where they were investigating this?

Thanks!

@fkorotkov
Copy link
Contributor

@rmistry let me check with them. Haven't heard anything so far. Do you have a link to a recent build?

@rmistry
Copy link

rmistry commented Dec 6, 2018

@fkorotkov Here is a recent roll that is stuck: flutter/engine#7104

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants