Skip to content

Conversation

@a14n
Copy link
Contributor

@a14n a14n commented Sep 11, 2018

No description provided.

@a14n a14n force-pushed the prefer_generic_function_type_aliases branch from 13d5f1b to d7535cc Compare September 14, 2018 06:16
@a14n
Copy link
Contributor Author

a14n commented Sep 14, 2018

@Hixie

- prefer_foreach
# - prefer_function_declarations_over_variables # not yet tested
# - prefer_generic_function_type_aliases # not yet tested
- prefer_generic_function_type_aliases
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's weird that this is called "generic function type" (as opposed to say "general function type", since it has nothing to do with generics.

@Hixie
Copy link
Contributor

Hixie commented Sep 14, 2018

LGTM

@a14n a14n merged commit a07d371 into flutter:master Sep 14, 2018
@a14n a14n deleted the prefer_generic_function_type_aliases branch September 14, 2018 19:06
hereisderek added a commit to hereisderek/flutter that referenced this pull request Sep 16, 2018
…dle-fix

* commit '1ad538e454c77496fbd068b9e8b5f8b61c2f6d96':
  Fix the @macro link in doc (flutter#21890)
  Track 90th, 99th percentile instead of missed_frame_build_budget_count (flutter#21754)
  24d9460 Roll Dart to bb56d4592f7cde38cdf0a04ad7f40d105af99d11 (flutter#21883)
  enable lint prefer_generic_function_type_aliases (flutter#21680)
  Roll engine 7a9b430..60bb5da (2 commits) (flutter#21880)
  Roll engine ade2d1d..7a9b430 (1 commits) (flutter#21878)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants