Rename test file to end with _test so it runs on the bots #21438
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvolkert
approved these changes
Sep 5, 2018
On Windows we get one message, but on Mac we get another (because of the Simulator always being available).
Contributor
Author
|
Tests behave different on Windows/Mac because on Mac there's always a simulator (so we get "Unable to find device with ID x") but on Windows there are zero devices so we get "Unable to locate a dev device. I've pushed a change that allows for either; please check you're ok with it. |
tvolkert
approved these changes
Sep 5, 2018
Contributor
tvolkert
left a comment
tvolkert
left a comment
There was a problem hiding this comment.
Too bad they both don't show up in the same stream, which would let us express this in terms of matchers...
LGTM
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.