Fix windows crash running flutter run which tries to find Xcode
#21423
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 5, 2018
Contributor
Author
|
Thanks! I'm landing this with the broken build because it seems very serious (all Windows and Linux users on master have a broken |
Contributor
Author
|
Actually, it is the cause of at least some of the failures (I mistakenly thought they were all running on Macs, but some are Linux): |
tvolkert
reviewed
Sep 5, 2018
| @@ -0,0 +1,44 @@ | |||
| // Copyright 2018 The Chromium Authors. All rights reserved. | |||
Contributor
There was a problem hiding this comment.
This needs to end in _test.dart in order to get run (it's be ignored right now)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #21418 which is a crash on Windows caused by trying to look for Xcode. It came in with #20758 which lost some platform filters on workflows.
It also adds an integration test that runs
flutter runwith an invaliddeviceIdto ensure that this code is exercised during builds (checking for devices is short-cut when we passflutter-tester).