No more nasty errors during flutter upgrade/channel on Windows #21085
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
I believe the logic around exit code 253 (outdated snapshot of Flutter Tools) is no longer necessary because we control which dart version ships with Flutter and whenever we change that version we create a new snapshot. Therefore, the snapshot should never be outdated. The logic is a relict from a time when Flutter used whatever Dart version was installed on the system. |
Member
Author
|
/cc @tvolkert @aam @timsneath |
aam
reviewed
Aug 27, 2018
| REM avoids nasty errors that may otherwise occure when the dart command (e.g. as | ||
| REM part of 'flutter upgrade') modifies this batch script while it is executing. | ||
| REM | ||
| REM Do not use the CALL command in the next line to execute Dart. CALL causes |
Member
There was a problem hiding this comment.
Whoa, who would have thought! Is this documented anywhere?
Member
Author
There was a problem hiding this comment.
I did not find any official documentation around this. There was one stack overflow answer explaining this behavior, but I can't find it now... :(
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14578.