Is this still needed now that package:test has distinguished expect() from expectLater()?

Ah sure. The lints in tests are for a variety of other random reasons. Patched those as well

Why not just return await process.exitCode; as it was before?

Oops, I was trying something else and forgot to revert everything

Can the server.onExit future ever complete with an error?

The comment was for the closure inside (in that if that closure has an error, it won't be handled by anyone (which is ok))

Thank you linter 😄 (and below)

This code's hard to parse (Future.wait(...).catchError(...).then(..., onError: ...)), which makes it hard to immediately see if we should be waiting for this here.

Can you refactor the inlined code herein into methods to make this a little more readable?

I think it's more that the formatting was unhelpful for readability. How is it now?

@devoncarew I couldn't understand this test enough to figure out why this hangs. Do you have any clues?

This test starts a daemon, send the daemon.shutdown command, and verifies that it shuts down. I don't know why responses.close() wouldn't return - I'd expect that a StreamController close to effectively return immediately.

I don't think it's necessary for this test to call responses.close() in any case.

ok, removed