Skip to content

Conversation

@Hixie
Copy link
Contributor

@Hixie Hixie commented Aug 20, 2018

Relands #20722, with the following change: "Use evalFlutter instead of startProcess. That way we don't need flutter on the PATH."

Hixie and others added 2 commits August 20, 2018 13:20
@Hixie
Copy link
Contributor Author

Hixie commented Aug 20, 2018

cc @tvolkert who reviewed the original

@Hixie
Copy link
Contributor Author

Hixie commented Aug 20, 2018

@fkorotkov Sorry to bug you again! the docs and tool_tests-linux shards here terminated in failure with no information in the logs to explain why. I don't think our code failed here; when either of the processes in question fail, they normally dump a message saying so. Any ideas?

Copy link
Contributor

@tvolkert tvolkert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Hixie
Copy link
Contributor Author

Hixie commented Aug 21, 2018

(restarted broken shards)

@fkorotkov
Copy link
Contributor

@Hixie I think I know what happened to these unexpectedly terminated shards! Seems like an issues with killing of a process tree. Just deployed a fix. Please let me know if you'll see it ever again.

@Hixie
Copy link
Contributor Author

Hixie commented Aug 21, 2018

@fkorotkov great! thanks!

@Hixie Hixie merged commit 22f3764 into flutter:master Aug 21, 2018
@Hixie Hixie deleted the deps branch August 21, 2018 21:02
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants