Performance test cleanup #20652
Merged
Performance test cleanup #20652
+14
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Hixie
commented
Aug 15, 2018
Hixie
commented
- Fix TODO syntax.
- Clarify messages for some timeouts, to aid debugging.
- Increase some other timeouts that were a needlessly short, to reduce sources of flakes.
- Remove some more timeouts that were mostly redundant, to remove complexity.
- Minor style cleanup.
- Remove some dangerous traps (specifically, hide the explicit start/end times in TimedEvent since they shouldn't matter).
* Fix TODO syntax. * Clarify messages for some timeouts, to aid debugging. * Increase some other timeouts that were a needlessly short, to reduce sources of flakes. * Remove some more timeouts that were mostly redundant, to remove complexity. * Minor style cleanup. * Remove some dangerous traps (specifically, hide the explicit start/end times in TimedEvent since they shouldn't matter).
cbracken
approved these changes
Aug 16, 2018
Contributor
Author
|
Thanks for the review. Will land on green. |
Hixie
added a commit
that referenced
this pull request
Aug 18, 2018
* Revert "Deprecated CupertinoDialog in favor of a new widget called CupertinoP… (#20649)" This reverts commit 3a4ae28. * Revert "Feature pesto new recipes (#19415)" This reverts commit e2f3b3d. * Revert "Use markdown table (#20721)" This reverts commit 82d43b9. * Revert "Documentation regarding tap gesture callbacks (#20647)" This reverts commit 3acc278. * Revert "Add branch to footer information in flutter docs (#20711)" This reverts commit 9118d3d. * Revert "Performance test cleanup (#20652)" This reverts commit 1993a67. * Revert "Track number of package dependencies in Flutter (#20722)" This reverts commit 03d6f18.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.