Skip to content

Conversation

@Hixie
Copy link
Contributor

@Hixie Hixie commented Aug 15, 2018

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are --> is

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might explain what an arena is, or link to an appropriate class. It's not that clear what is meant by arena if this is the first gesture class you encounter.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@Hixie
Copy link
Contributor Author

Hixie commented Aug 16, 2018

will land on green

@Hixie
Copy link
Contributor Author

Hixie commented Aug 16, 2018

@fkorotkov Hard to say if it's our problem or yours, but the tests-windows shard here spun around doing nothing for like an hour. Then it did some more stuff and then eventually timed out. At a guess, there's some sort of resource starvation going on in the Windows cluster.

@fkorotkov
Copy link
Contributor

@Hixie me and @gspencergoog saw that but there were issues with reporting logs for such timed out tasks. I fixed it yesterday and at least now there are logs presented every time (they were missing sometimes for timed out tasks).

It seems it was hanging on running slivers_evil_test.dart.

If you are interested I can pretty easy add a way to run windows containers on GCP instead of Azure. The only problem will be that Windows Contianers on GCP will start in 4-5 minutes instead of 1:30-2 on Azure. But we can check if it will be more stable.

@Hixie
Copy link
Contributor Author

Hixie commented Aug 16, 2018

@fkorotkov It looks like it spent 30 minutes on one test, then 30 minutes on another test. Hard to tell for sure exactly what was happening, but I've never seen that on any other platform, which is why I suspect some sort of resource starvation (e.g. maybe a disk read took a really long time). I don't have a strong opinion on how Cirrus implements things. :-)

@Hixie
Copy link
Contributor Author

Hixie commented Aug 16, 2018

Full logs of failing run: 5708719757197312-test_all.log

@Hixie
Copy link
Contributor Author

Hixie commented Aug 17, 2018

@fkorotkov I ran it again and this time it was 60 minutes on a different test (C:\Windows\Temp\flutter sdk\packages\flutter_localizations\test\date_picker_test.dart: DayPicker shows dates for ar_AR). I'll rerun it again.

Log of that failing run: 5694495647596544-test_all.log

@Hixie Hixie merged commit 3acc278 into flutter:master Aug 17, 2018
@Hixie Hixie deleted the gesture_docs branch August 17, 2018 21:31
Hixie added a commit that referenced this pull request Aug 18, 2018
Hixie added a commit that referenced this pull request Aug 18, 2018
* Revert "Deprecated CupertinoDialog in favor of a new widget called CupertinoP… (#20649)"

This reverts commit 3a4ae28.

* Revert "Feature pesto new recipes (#19415)"

This reverts commit e2f3b3d.

* Revert "Use markdown table (#20721)"

This reverts commit 82d43b9.

* Revert "Documentation regarding tap gesture callbacks (#20647)"

This reverts commit 3acc278.

* Revert "Add branch to footer information in flutter docs (#20711)"

This reverts commit 9118d3d.

* Revert "Performance test cleanup (#20652)"

This reverts commit 1993a67.

* Revert "Track number of package dependencies in Flutter (#20722)"

This reverts commit 03d6f18.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants