-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Documentation regarding tap gesture callbacks #20647
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are --> is
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You might explain what an arena is, or link to an appropriate class. It's not that clear what is meant by arena if this is the first gesture class you encounter.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
|
will land on green |
|
@fkorotkov Hard to say if it's our problem or yours, but the tests-windows shard here spun around doing nothing for like an hour. Then it did some more stuff and then eventually timed out. At a guess, there's some sort of resource starvation going on in the Windows cluster. |
|
@Hixie me and @gspencergoog saw that but there were issues with reporting logs for such timed out tasks. I fixed it yesterday and at least now there are logs presented every time (they were missing sometimes for timed out tasks). It seems it was hanging on running If you are interested I can pretty easy add a way to run windows containers on GCP instead of Azure. The only problem will be that Windows Contianers on GCP will start in 4-5 minutes instead of 1:30-2 on Azure. But we can check if it will be more stable. |
|
@fkorotkov It looks like it spent 30 minutes on one test, then 30 minutes on another test. Hard to tell for sure exactly what was happening, but I've never seen that on any other platform, which is why I suspect some sort of resource starvation (e.g. maybe a disk read took a really long time). I don't have a strong opinion on how Cirrus implements things. :-) |
|
Full logs of failing run: 5708719757197312-test_all.log |
|
@fkorotkov I ran it again and this time it was 60 minutes on a different test ( Log of that failing run: 5694495647596544-test_all.log |
* Revert "Deprecated CupertinoDialog in favor of a new widget called CupertinoP… (#20649)" This reverts commit 3a4ae28. * Revert "Feature pesto new recipes (#19415)" This reverts commit e2f3b3d. * Revert "Use markdown table (#20721)" This reverts commit 82d43b9. * Revert "Documentation regarding tap gesture callbacks (#20647)" This reverts commit 3acc278. * Revert "Add branch to footer information in flutter docs (#20711)" This reverts commit 9118d3d. * Revert "Performance test cleanup (#20652)" This reverts commit 1993a67. * Revert "Track number of package dependencies in Flutter (#20722)" This reverts commit 03d6f18.
cc @gspencergoog