Reland "Roll engine to version e3687f70c7ece72000b32ee1b3c02755ba5361ac (#20427)" #20633
Conversation
This is a re-land with downgraded `package:flutter_gallery_assets` version.
|
There seems to be still issues, even though the presubmit checks don't cover it. I think it has to do with inconsistent usage of |
| description: A new flutter project. | ||
|
|
||
| environment: | ||
| # The pub client defaults to an <2.0.0 sdk constraint which we need to explicitly overwrite. |
There was a problem hiding this comment.
This is really strange we have a constraint like that. Could it be that it is 'older' pub clients that default to <2.0.0 sdk constraint, but we should not be relying on them?
There was a problem hiding this comment.
This was added here:
"""
There is now a default SDK constraint of <2.0.0 for any package with no
existing upper bound. This allows us to move more safely to 2.0.0. All new
packages published on pub will now require an upper bound SDK constraint so
future major releases of Dart don't destabilize the package ecosystem.
"""
… earlier commit)
mkustermann
changed the title
|
This regressed memory usage on the flutter_gallery__memory_nav benchmark quite severely. |
|
@Hixie After the roll I've checked the benchmarks and filed #20690. The suspicion so far seems this was caused by engine change flutter/engine@149ea7b (see the issue) |
7 participants
This is a re-land with downgraded
package:flutter_gallery_assetsversion, which appears to have a weired sdk constraint allowing this particular dart sdk to be compatible, namely it uses>=1.19.0 <2.1.0