Shim package:test to avoid matcher issues #20602
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvolkert
reviewed
Aug 14, 2018
dev/bots/test.dart
Outdated
Contributor
There was a problem hiding this comment.
Why not put this in flutter_tools/test/forbidden_imports_test.dart?
Contributor
There was a problem hiding this comment.
Ah, because it applies to more than flutter_tools 😄
Contributor
Author
There was a problem hiding this comment.
That only checks flutter_tools. This checks the whole repo.
dev/bots/test.dart
Outdated
Contributor
There was a problem hiding this comment.
Could you list the locations of the shims in the error message?
Hixie
force-pushed
the
matcher
branch
2 times, most recently
from
c2f4650 to
9b91f14
Compare
Contributor
Author
|
Ok assuming the bots go green this should be good to go. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @tvolkert @jonahwilliams
This isn't quite done yet (I haven't tested bytest.dartchange and I need to remove some more dependencies onpackage:test) but I figured I'd give you a head start on reviewing it.