Skip to content

Flutter tool support for dynamic code #20543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sbaranov merged 1 commit into from
Aug 15, 2018
Merged

Flutter tool support for dynamic code #20543

sbaranov merged 1 commit into from
Aug 15, 2018

Conversation

@sbaranov
Copy link
Contributor

@sbaranov sbaranov commented Aug 13, 2018 •
edited
Loading

This change adds --dynamic flag to the flutter tool, which makes it use the engine produced by gn --dynamic that includes support for dynamic code in profile and release configurations.

@sbaranov sbaranov requested review from Hixie and aam August 14, 2018 16:25
aam
aam reviewed Aug 15, 2018
View reviewed changes
packages/flutter_tools/gradle/flutter.gradle Outdated
Copy link
Member

@aam aam Aug 15, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comment above at line 75 seems to need to be updated

Copy link
Contributor Author

@sbaranov sbaranov Aug 15, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

aam
aam reviewed Aug 15, 2018
View reviewed changes
packages/flutter_tools/gradle/flutter.gradle Outdated
Copy link
Member

@aam aam Aug 15, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is setting matchingFallbacks like this for these dynamic configurations as intended?

Copy link
Contributor Author

@sbaranov sbaranov Aug 15, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect this setting is inconsequential. It only matters if one of flutter's dependency modules doesn't define given build configuration, and I don't see any sub-modules.

Copy link
Member

@aam aam Aug 15, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @mravn-google in case he knows

@sbaranov sbaranov changed the title Flutter tool support for dynamic code loading Flutter tool support for dynamic code Aug 15, 2018
@sbaranov sbaranov merged commit 25ba90a into flutter:master Aug 15, 2018
@sbaranov sbaranov deleted the flutter-dynamic-flag branch August 15, 2018 19:28
jonahwilliams pushed a commit that referenced this pull request Aug 15, 2018
Revert "Flutter tool support for dynamic code. (#20543)"
c9bc43d 
This reverts commit 25ba90a.
@jonahwilliams jonahwilliams mentioned this pull request Aug 15, 2018
Merged
@tvolkert
Copy link
Contributor

tvolkert commented Aug 15, 2018

Seeing the following errors with this commit:

2018-08-15T13:02:25.952290: stderr: 
2018-08-15T13:02:25.952794: stderr: Invalid argument(s): Could not find an option named "dynamic".
2018-08-15T13:02:25.953261: stderr: #0      ArgResults.[] (package:args/src/arg_results.dart:64:7)
stderr: #1      FlutterCommand.getBuildMode (package:flutter_tools/src/runner/flutter_command.dart:176:24)
stderr: #2      FlutterCommand.getBuildInfo (package:flutter_tools/src/runner/flutter_command.dart:218:26)
2018-08-15T13:02:25.953391: stderr: #3      BuildIOSCommand.runCommand (package:flutter_tools/src/commands/build_ios.dart:74:33)
stderr: 
stderr: #4      FlutterCommand.verifyThenRunCommand (package:flutter_tools/src/runner/flutter_command.dart:353:18)
stderr: 
stderr: #5      FlutterCommand.run. (package:flutter_tools/src/runner/flutter_command.dart:287:33)
stderr: 
stderr: #6      AppContext.run. (package:flutter_tools/src/base/context.dart:142:29)
stderr: 
stderr: #7      _rootRun (dart:async/zone.dart:1124:13)

@tvolkert
Copy link
Contributor

tvolkert commented Aug 15, 2018

I see this is being reverted in #20644

jonahwilliams pushed a commit that referenced this pull request Aug 15, 2018
Revert "Flutter tool support for dynamic code" (#20644)
58e52cc 
* Revert "iOS Dialog blur, brightness, and layout (#18381)"

This reverts commit 21bc9f1.

* Revert "Flutter tool support for dynamic code. (#20543)"

This reverts commit 25ba90a.
sbaranov added a commit that referenced this pull request Aug 16, 2018
@sbaranov
Reland Flutter tool support for dynamic code #20543 (#20646)
393f927
@jmagman jmagman mentioned this pull request Jul 21, 2021
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@aam aam aam approved these changes

@Hixie Hixie Awaiting requested review from Hixie

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sbaranov @tvolkert @aam @googlebot