Fix broken Flutter module with plugins #20496
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sigurdm
approved these changes
Aug 13, 2018
| mockXcodeProjectInterpreter = new MockXcodeProjectInterpreter(); | ||
| projectUnderTest = await FlutterProject.fromDirectory(fs.directory('project')); | ||
| projectUnderTest.ios.directory.createSync(recursive: true); | ||
| projectUnderTest.ios.directory..childDirectory('Runner.xcodeproj').createSync(recursive: true); |
Contributor
Author
There was a problem hiding this comment.
Because
a..b().c()
calls c on the return value of b, not on the value of a. However, the overall expression has the value of a. I'll remove one ..
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 13, 2020
zanderso
pushed a commit
that referenced
this pull request
Oct 13, 2020
* 85b0031 Migration to PlatformDispatcher and multi-window (flutter/engine#20496) * 0d15181 Remove uses of Dart VM bytecode mode from Flutter engine (flutter/engine#21741) * 8be6cc0 Roll Skia from 88cda17bbeb8 to 61003cde7688 (4 revisions) (flutter/engine#21744) * a2046ae Revert "fix On iOS, dialog titles are announced twice (#19826)" (flutter/engine#21714) * 3bd695b Roll Skia from 61003cde7688 to 13fc260c7080 (1 revision) (flutter/engine#21746) * ca250c9 Roll Fuchsia Mac SDK from lqn8xmlDn... to gzhbqRUap... (flutter/engine#21749) * 7f0e17b Roll Skia from 13fc260c7080 to aa64c352b349 (1 revision) (flutter/engine#21752) * d97e74c Roll Fuchsia Linux SDK from EBX49sN_X... to YRTc9YoiB... (flutter/engine#21753) * 7fc1a03 Roll Skia from aa64c352b349 to d71dc2d25b8b (1 revision) (flutter/engine#21758) * a3f3f98 Roll Fuchsia Mac SDK from gzhbqRUap... to _0R2HD4c8... (flutter/engine#21759) * d4b8d67 Roll Fuchsia Linux SDK from YRTc9YoiB... to Nw5-0_sVF... (flutter/engine#21760) * 910ce92 Roll Fuchsia Mac SDK from _0R2HD4c8... to 82ankF-Ht... (flutter/engine#21762) * bd03014 Roll Fuchsia Mac SDK from 82ankF-Ht... to FFpTJfmj1... (flutter/engine#21768) * f230fde Use buildroot clang for scenario app (flutter/engine#21690) * 766d682 Roll Fuchsia Linux SDK from Nw5-0_sVF... to h-DeV4tgE... (flutter/engine#21771) * cff4ee7 Roll Skia from d71dc2d25b8b to ceb6214a556a (5 revisions) (flutter/engine#21772) * fd1ba9c Ignore analysis warning for doc comment (flutter/engine#21773) * 978cfd6 Roll Skia from ceb6214a556a to 9213e610ed92 (8 revisions) (flutter/engine#21774) * 1068429 Roll Dart SDK from 06536d68ca0f to e256855d07ba (6 revisions) (flutter/engine#21775) * 190fd8e Reland "Create root isolate asynchronously (#20142)" (flutter/engine#21747) * 10ed563 Roll Skia from 9213e610ed92 to 840e8ea7403e (11 revisions) (flutter/engine#21779) * e18cd96 Roll Skia from 840e8ea7403e to ab6e62c131e9 (7 revisions) (flutter/engine#21783) * 931a046 Fix documentation build for window changes. (flutter/engine#21780) * 38d8eba E2e screenshot tests2 (flutter/engine#21383) * d912d50 [null-safety] fix build rule to produce sound dill (flutter/engine#21784) * 05d9793 Extract a TextRange class for selection (flutter/engine#21722) * c2938d0 Revert "Migration to PlatformDispatcher and multi-window #20496" (flutter/engine#21792)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flutter modules with plugins were broken, code path tripping over unfinished iOS support.
This PR removes the breakage and adds test coverage. The underlying issue of missing iOS support will be addressed by another PR.
This PR also removes a Java compiler warning (newly deprecated engine API).