Update goldens and roll engine to ecbb2b28d48a3854aba846da38053cf381cced25 #20230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liyuqian
force-pushed
the
engine_roll_97aea093e6bc0437eede2a0340c3474f2085fc61
branch
from
6fe1931 to
ebcd526
Compare
Contributor
|
nit: I missed that this is a goldens roll as well, maybe include in the PR title roll engine and goldens? |
liyuqian
changed the title
Contributor
Author
|
@amirh Done, thanks! |
ecbb2b2 Call drawPaint instead of drawPath if there's clip (flutter/engine#5937) 597a508 Roll src/third_party/skia cdfa16d086b8..4c3b63e289c5 (9 commits) (flutter/engine#5936) 715b64e Roll src/third_party/skia 1400d38e0863..cdfa16d086b8 (10 commits) (flutter/engine#5934) ffbafc8 Flush all embedded Android views on hot restart. (flutter/engine#5929) 9fe6a57 Roll src/third_party/skia 578ef2847b72..1400d38e0863 (7 commits) (flutter/engine#5933) 3b66f20 Don't drop MotionEvents with unknown tool type. (flutter/engine#5931) 391ac2f Roll src/third_party/skia 64cc576b1fa7..578ef2847b72 (20 commits) (flutter/engine#5930) Goldens: 64b7a3a Add updated golden files cb1fa8a Update golden files of PhysicalModel and PhysicalShape 3baed8d Add a goldens package for the embedded Android views integration test.
liyuqian
force-pushed
the
engine_roll_97aea093e6bc0437eede2a0340c3474f2085fc61
branch
from
ebcd526 to
f01f69c
Compare
liyuqian
changed the title
Contributor
|
This roll caused major performance regressions. |
Contributor
Author
|
@Hixie yes, it should be fixed by flutter/engine#5952 . I'll discuss the tests with you tomorrow. |
liyuqian
deleted the
engine_roll_97aea093e6bc0437eede2a0340c3474f2085fc61
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ecbb2b2 Call drawPaint instead of drawPath if there's clip (flutter/engine#5937)
597a508 Roll src/third_party/skia cdfa16d086b8..4c3b63e289c5 (9 commits) (flutter/engine#5936)
715b64e Roll src/third_party/skia 1400d38e0863..cdfa16d086b8 (10 commits) (flutter/engine#5934)
ffbafc8 Flush all embedded Android views on hot restart. (flutter/engine#5929)
9fe6a57 Roll src/third_party/skia 578ef2847b72..1400d38e0863 (7 commits) (flutter/engine#5933)
3b66f20 Don't drop MotionEvents with unknown tool type. (flutter/engine#5931)
391ac2f Roll src/third_party/skia 64cc576b1fa7..578ef2847b72 (20 commits) (flutter/engine#5930)
Goldens:
64b7a3a Add updated golden files
cb1fa8a Update golden files of PhysicalModel and PhysicalShape
3baed8d Add a goldens package for the embedded Android views integration test.