Skip to content

Increase time picker clock touch targets to 48 by 48 #19936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jonahwilliams merged 3 commits into from
Jul 30, 2018
Merged

Increase time picker clock touch targets to 48 by 48 #19936

jonahwilliams merged 3 commits into from
Jul 30, 2018

Conversation

@jonahwilliams
Copy link
Contributor

@jonahwilliams jonahwilliams commented Jul 28, 2018 •
edited
Loading

Partial work towards #18130, still requires AM/PM and Hour changes

Fixes #19912

@gspencergoog
Copy link
Contributor

gspencergoog commented Jul 30, 2018

32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

@jonahwilliams jonahwilliams merged commit dfe5b59 into flutter:master Jul 30, 2018
@jonahwilliams jonahwilliams deleted the time_picker branch August 4, 2018 02:15
@darrenaustin darrenaustin mentioned this pull request May 3, 2019
Merged
9 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@gspencergoog gspencergoog gspencergoog approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Traversal order of clock on TimePicker is incorrect

3 participants

@jonahwilliams @gspencergoog @googlebot