Skip to content

Roll engine to 72a38a6b1343ec09a8d884fff655bfbc8cb01674 #19923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
liyuqian merged 1 commit into from
Jul 28, 2018
Merged

Roll engine to 72a38a6b1343ec09a8d884fff655bfbc8cb01674 #19923

liyuqian merged 1 commit into from
Jul 28, 2018

Conversation

@liyuqian
Copy link
Contributor

@liyuqian liyuqian commented Jul 27, 2018 •
edited by amirh
Loading 

72a38a6b1 Build Android engine in presubmit using Cirrus and GCE (#5882)
f9f40badd Log uncaught exceptions from JNI calls at a higher priority (#5891)
723b2784d Update license script README (#5890)
9420da1e2 Roll src/third_party/skia 9acfc6cac2c6..227424b57d28 (10 commits) (#5888)
27c9de59b Roll src/third_party/skia 55b1e6168454..9acfc6cac2c6 (1 commits) (#5887)
8b8c52ed7 Roll src/third_party/skia b935cf8e12d7..55b1e6168454 (1 commits) (#5886)
89602cc64 [scenic] Expose compositor context from rasterizer. (#5739)
9baeb9c1a Roll src/third_party/skia 5f1dc76d0cec..b935cf8e12d7 (1 commits) (#5885)

@liyuqian
Roll engine to 72a38a6
f9e3573 
72a38a6 Build Android engine in presubmit using Cirrus and GCE (flutter#5882)
f9f40ba Log uncaught exceptions from JNI calls at a higher priority (flutter#5891)
723b278 Update license script README (flutter#5890)
9420da1 Roll src/third_party/skia 9acfc6cac2c6..227424b57d28 (10 commits) (flutter#5888)
27c9de5 Roll src/third_party/skia 55b1e6168454..9acfc6cac2c6 (1 commits) (flutter#5887)
8b8c52e Roll src/third_party/skia b935cf8e12d7..55b1e6168454 (1 commits) (flutter#5886)
89602cc [scenic] Expose compositor context from rasterizer. (flutter#5739)
9baeb9c Roll src/third_party/skia 5f1dc76d0cec..b935cf8e12d7 (1 commits) (flutter#5885)
amirh
amirh approved these changes Jul 28, 2018
View reviewed changes
Copy link
Contributor

@amirh amirh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amirh
Copy link
Contributor

amirh commented Jul 28, 2018

nit: wrap the rev list in back ticks to prevent referencing a bunch of unrelated issues

@liyuqian liyuqian merged commit f2a983f into flutter:master Jul 28, 2018
@liyuqian liyuqian deleted the engine_roll_72a38a6b1343ec09a8d884fff655bfbc8cb01674 branch August 27, 2018 23:18
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@amirh amirh amirh approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@liyuqian @amirh @googlebot