-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Update state of BottomNavigationBar if background updates #19661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
|
I signed it! |
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
8901a36 to
dc6716f
Compare
|
CLAs look good, thanks! |
|
I am not sure if I am supposed to add a test. I looked in the current tests, but nothing is testing the color of the widget (neither should I know how to do it). So I think we need to accept this is untestable? |
|
@HansMuller is there anything I can do to expedite the review of this pull request? I mention you because on https://github.com/flutter/flutter/wiki/Triage it mentions you as the Material widget specialist :) |
|
@nathansamson |
|
Since this fix had been idling for so long, I created a new PR, updated it, and added a regression test: #20890. |
This tracks the backgroundColor of the selected item and updates the widget accordingly.
Note that I do not fully understand why we need to keep track of the
_backgroundColor(and usewidget.items[widget.currentIndex].backgroundColordirectly...Fixes #19653