Skip to content

Conversation

@nathansamson
Copy link

This tracks the backgroundColor of the selected item and updates the widget accordingly.

Note that I do not fully understand why we need to keep track of the _backgroundColor (and use widget.items[widget.currentIndex].backgroundColor directly...

Fixes #19653

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@nathansamson
Copy link
Author

I signed it!

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

@nathansamson nathansamson force-pushed the nathan/fix-issue-19653 branch from 8901a36 to dc6716f Compare July 22, 2018 12:30
@googlebot
Copy link

CLAs look good, thanks!

@nathansamson
Copy link
Author

I am not sure if I am supposed to add a test.

I looked in the current tests, but nothing is testing the color of the widget (neither should I know how to do it). So I think we need to accept this is untestable?
Please correct me if I am wrong

@nathansamson
Copy link
Author

@HansMuller is there anything I can do to expedite the review of this pull request?

I mention you because on https://github.com/flutter/flutter/wiki/Triage it mentions you as the Material widget specialist :)

@HansMuller
Copy link
Contributor

@nathansamson
Sorry about the inexplicable delay in reviewing this. I'm looking now.

@HansMuller
Copy link
Contributor

Since this fix had been idling for so long, I created a new PR, updated it, and added a regression test: #20890.

@HansMuller HansMuller closed this Aug 22, 2018
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BottomNavigationBar uses the wrong theme

3 participants