Repository navigation
Conversation
A realized renderer may still receive an in-flight frame after forced GTK disposal while a strong reference is held. Keep the task runner and frame mutex alive with the compositor until finalization. Fixes flutter#196545. Validation: failing original regression reproduced under GDB; fixed regression passed 100 repetitions; all 862 Linux engine unit tests passed.
10 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A realized software renderer can still present a frame after GTK destroys its widget while a strong reference keeps the instance alive.
dispose()currently clearstask_runner;present_layers()then reachesfl_task_runner_stop_wait(nullptr)and crashes ing_cond_signal().Keep the task runner and frame mutex until
finalize(), alongside the existing compositor and surface lifetime. Add a realized-widget regression; the existing unrealized-widget test returns before reaching this path.Fixes #196545.
Related: #193533 handles OpenGL/Subsurface lifetime. This change is limited to the software renderer.
Validation
215858ff8a1e51fb5481c7c7cc4c6d4be54b8ae0; the symbolized stack showsfl_task_runner_stop_wait(self=0x0).Prepared with Codex assistance. Kept as a draft for contributor review under the AI contribution guidelines.
Pre-launch Checklist
///).