Repository navigation
[SwiftPM] Disable tests for when settings fail to compile - #196310
Merged
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request modifies swift_package_manager_integration_migration_test.dart to skip two tests, referencing an open issue. The feedback suggests passing the issue URL string directly to the skip parameter instead of true to allow the test runner to output the reason when the tests are skipped.
| ); | ||
| expect(testLogger.traceText, contains('Sending crash report to Google.')); | ||
| }); | ||
| }, skip: true); // https://github.com/flutter/flutter/issues/196307 |
Contributor
There was a problem hiding this comment.
In Dart's test package, the skip parameter can accept a string explaining the reason or linking to the issue. Using a string instead of true allows the test runner to output the reason/URL when the test is skipped, which is highly beneficial for tracking skipped tests.
Suggested change
| }, skip: true); // https://github.com/flutter/flutter/issues/196307 | |
| }, skip: 'https://github.com/flutter/flutter/issues/196307'); |
| ); | ||
| expect(testLogger.traceText, contains('Sending crash report to Google.')); | ||
| }); | ||
| }, skip: true); // https://github.com/flutter/flutter/issues/196307 |
Contributor
There was a problem hiding this comment.
In Dart's test package, the skip parameter can accept a string explaining the reason or linking to the issue. Using a string instead of true allows the test runner to output the reason/URL when the test is skipped, which is highly beneficial for tracking skipped tests.
Suggested change
| }, skip: true); // https://github.com/flutter/flutter/issues/196307 | |
| }, skip: 'https://github.com/flutter/flutter/issues/196307'); |
jmagman
approved these changes
Nov 10, 2026
jmagman
left a comment
jmagman
left a comment
Member
There was a problem hiding this comment.
Bot may be right, but it's a nit, LGTM to reopen the tree
vashworth
approved these changes
Nov 10, 2026
github-actions
Bot
added
tool
vashworth
added
the
emergency
|
Detected the If you add the The "Merge" button is also unlocked. To bypass presubmits as well as the tree status, press the GitHub "Add to Merge Queue". |
vashworth
added
the
autosubmit
flutter-dashboard
Bot
removed
the
autosubmit
bkonyi
added a commit
to bkonyi/flutter
that referenced
this pull request
Nov 10, 2026
Merge `origin/master` and re-enable the two `validate project settings` tests in `swift_package_manager_integration_migration_test.dart` that were temporarily skipped in flutter#196310. Previous output: ``` 00:32 +3002 ~2 -1: test/general.shard/migrations/swift_package_manager_integration_migration_test.dart: Flutter Package Migration validate project settings throw if settings fail to compile [E] TimeoutException after 0:00:02.000000: Test timed out after 2 seconds. dart:isolate _RawReceivePort._handleMessage ``` Current output: ``` +156: All tests passed! ``` Fixes flutter#196307
11 tasks done
10 tasks done
auto-submit Bot
pushed a commit
to flutter/packages
that referenced
this pull request
Nov 11, 2026
flutter/flutter@fffd8c2...b98afb5 2026-11-11 [email protected] Roll Dart SDK from 172cf8f121c0 to 8f15c4ca2d41 (1 revision) (flutter/flutter#196367) 2026-11-11 [email protected] Roll Skia from 657283e78115 to cc4c54f752ba (5 revisions) (flutter/flutter#196365) 2026-11-11 [email protected] Roll Skia from 2605c4a9761c to 657283e78115 (1 revision) (flutter/flutter#196358) 2026-11-11 [email protected] Roll Dart SDK from 890c6d15334c to 172cf8f121c0 (1 revision) (flutter/flutter#196352) 2026-11-11 [email protected] [flutter_tools] Migrate general.shard project, runner, and web tests off globals (flutter/flutter#196128) 2026-11-11 [email protected] [flutter_tools] Migrate test helpers and integration tests off globals (flutter/flutter#196124) 2026-11-11 [email protected] [web] Report skwasm WebGL context creation failure instead of hanging (flutter/flutter#193293) 2026-11-11 [email protected] [flutter_tools] Migrate commands.shard tests off globals (flutter/flutter#196139) 2026-11-11 [email protected] [devicelab] Fix memory benchmark tap synchronization and swipe flakes (flutter/flutter#194457) 2026-11-11 [email protected] Roll Skia from 06062e36d938 to 2605c4a9761c (2 revisions) (flutter/flutter#196350) 2026-11-11 [email protected] Do not wait again for a closed mock event stream in tear down (flutter/flutter#196110) 2026-11-11 [email protected] [gen_l10n] Add `use-explicit-plural-values` option (flutter/flutter#194816) 2026-11-11 [email protected] Roll Skia from 7bd33f8a3b70 to 06062e36d938 (2 revisions) (flutter/flutter#196340) 2026-11-11 [email protected] Skip redundant work in plugin_test_* (flutter/flutter#196258) 2026-11-10 [email protected] Drop test_timeout_secs from shards that no longer need it (flutter/flutter#196277) 2026-11-10 [email protected] Roll Dart SDK from 15c1699d3eeb to 890c6d15334c (1 revision) (flutter/flutter#196321) 2026-11-10 [email protected] iOS: Extract FlutterPlatformViewsController platform-thread state to Obj-C (flutter/flutter#196142) 2026-11-10 [email protected] Remove `Mac web_tool_tests` and take new subshard builders out of bringup (flutter/flutter#196276) 2026-11-10 [email protected] Roll Skia from 9c3d43d8a04b to 7bd33f8a3b70 (12 revisions) (flutter/flutter#196317) 2026-11-10 [email protected] Take customer_testing_devtools out of bringup (flutter/flutter#196239) 2026-11-10 [email protected] Roll ICU from a0ea93436c52 to b09986242cfb (1 revision) (flutter/flutter#196316) 2026-11-10 [email protected] [flutter_tools] Avoid unlinking native_assets.json and handle EXDEV (flutter/flutter#196134) 2026-11-10 [email protected] Remove old `Windows tool_integration_tests` builders and take the new shards out of bringup (flutter/flutter#196275) 2026-11-10 [email protected] [SwiftPM] Disable tests for when settings fail to compile (flutter/flutter#196310) 2026-11-10 [email protected] Roll Fuchsia Test Scripts from PXc5D7S_q6sIYpfFJ... to oEU515sDqSTvD8Spx... (flutter/flutter#196289) 2026-11-10 [email protected] Fix ime insets animation jump (flutter/flutter#191453) 2026-11-10 [email protected] Link to original PR in automatic cherry-pick PRs (flutter/flutter#196130) 2026-11-10 [email protected] Roll Packages from 565c657 to 08faf64 (9 revisions) (flutter/flutter#196296) 2026-11-10 [email protected] Roll Skia from b11315d0a096 to 9c3d43d8a04b (45 revisions) (flutter/flutter#196295) 2026-11-10 [email protected] Replace type-specific window widgets with a single Window widget (flutter/flutter#196002) 2026-11-10 [email protected] Roll Dart SDK from a2baae273bb2 to 15c1699d3eeb (2 revisions) (flutter/flutter#196294) If this roll has caused a breakage, revert this CL and set the roller to dry run mode using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
bkonyi
added a commit
to bkonyi/flutter
that referenced
this pull request
Nov 11, 2026
…ter#196315) Previously, `SwiftPackageManagerIntegrationMigration` accepted `required bool reportCrashes` and instantiated `CrashReportSender` inline with an unmocked `http.Client()`. As a result, the `validate project settings` unit tests in `swift_package_manager_integration_migration_test.dart` made live HTTPS `POST` requests to `https://clients2.google.com/cr/report`, causing `tool_tests_general` presubmits to fail with `TimeoutException` whenever the remote endpoint took longer than 2 seconds. Replace `bool reportCrashes` with an optional `CrashReportSender Function()? crashReportSenderFactory` passed at the `buildXcodeProject` and `buildMacOS` production call sites (when `!botDetector.isRunningOnBot`) so `CrashReportSender` and its `http.Client` are only allocated when a migration crash occurs, pass a `FakeCrashReportSender` factory in `swift_package_manager_integration_migration_test.dart`, and re-enable the two `validate project settings` tests that were temporarily skipped in flutter#196310. Fixes flutter#196307 Previous output: ``` 00:32 +3002 ~2 -1: test/general.shard/migrations/swift_package_manager_integration_migration_test.dart: Flutter Package Migration validate project settings throw if settings fail to compile [E] TimeoutException after 0:00:02.000000: Test timed out after 2 seconds. dart:isolate _RawReceivePort._handleMessage ``` Current output: ``` +157: All tests passed! ``` ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [AI contribution guidelines] and understand my responsibilities, or I am not using AI tools. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant in-code documentation (doc comments with `///`). - [x] If this PR introduces a new feature or capability, I created and linked a website documentation issue or PR in [flutter/website] (or verified none is needed). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [AI contribution guidelines]: https://github.com/flutter/flutter/blob/main/CONTRIBUTING.ai.md [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [flutter/website]: https://github.com/flutter/website [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tree is closed due to test failures: https://ci.chromium.org/ui/p/flutter/builders/prod/Linux%20tool_tests_general/31207/overview
Issue to track re-enabling these tests: #196307