Repository navigation
Conversation
github-actions
Bot
added
tool
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces logic to override a Swift package's minimum deployment target when its dependencies require a higher version. It refactors manifest parsing, copies plugins requiring overrides, and updates their manifests accordingly. Feedback on the changes suggests improving error handling by checking the exit code of the swift package dump-package command, updating the regular expression for detecting package declarations to support explicit type annotations, and caching parsed manifests to prevent redundant process spawns.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Swift Package Manager requires a package's minimum deployment target to be at least as high as the targets of its dependencies.
Inter-plugin dependencies (when a Flutter plugin has a dependency on another Flutter plugin) are specially sensitive to this since increasing the minimum deployment target of a Flutter plugin hasn't historically required a major version change, whereas SwiftPM packages are expected to publish such a change as a major version change.
This PR introduces a workaround specifically for inter-plugin dependencies that checks if a plugin's inter-plugin dependencies have a higher required platform version. If it does, it copies the plugin and inject an override into the Package.swift like this:
Fixes #194871.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
If this change needs to override an active code freeze, provide a comment explaining why. The code freeze workflow can be overridden by code reviewers. See pinned issues for any active code freezes with guidance.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.