Repository navigation
Conversation
CarouselScrollPhysics snaps to item boundaries, but extends ScrollPhysics directly rather than PageScrollPhysics. When a CarouselView with itemSnapping: true is wrapped in a SelectionArea, drag-selecting text past the edge of the carousel with a mouse triggers the scrollable's auto-scroll, snapping to the next item rather than extending the selection. This overrides allowSelectionEdgeScrolling to false on CarouselScrollPhysics, following the same behavior introduced for PageScrollPhysics in flutter#189544. Fixes flutter#190737
github-actions
Bot
added
framework
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CarouselScrollPhysicssnaps to item boundaries, but extendsScrollPhysicsdirectly rather thanPageScrollPhysics. When aCarouselViewwithitemSnapping: trueis wrapped in aSelectionArea, drag-selecting text past the edge of the carousel with a mouse triggers edge auto-scrolling, which snaps to the next item instead of extending the selection.Follow-up to #189544: this overrides
allowSelectionEdgeScrollingtofalseinCarouselScrollPhysics, matching the behavior established forPageScrollPhysics.Fixes #190737
Pre-launch Checklist
///).