Skip to content

Roll Skia from b11315d0a096 to be4196b7f537 (3 revisions) - #196144

Closed
engine-flutter-autoroll wants to merge 1 commit into
flutter:masterfrom
engine-flutter-autoroll:skia-flutter-autoroll-f6416106-7a04-42fd-8120-18ea6898180e-1794007514
Closed

engine-flutter-autoroll wants to merge 1 commit into
flutter:masterfrom
engine-flutter-autoroll:skia-flutter-autoroll-f6416106-7a04-42fd-8120-18ea6898180e-1794007514

Conversation

@engine-flutter-autoroll

Copy link
Copy Markdown
Contributor

https://skia.googlesource.com/skia.git/+log/b11315d0a096..be4196b7f537

2026-11-06 [email protected] [skparagraph] Close glyph and text ranges in OneLineShaper::clusteredText
2026-11-06 skia-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com Manual roll agents-internal from 11c700b10e17 to f85c3dd9f282 (21 revisions)
2026-11-06 [email protected] [skparagraph] Cap letter spacing line shift

If this roll has caused a breakage, revert this CL and set the roller
to dry run mode using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@engine-flutter-autoroll engine-flutter-autoroll added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 6, 2026
@flutter-dashboard flutter-dashboard Bot added the CICD Run CI/CD label Nov 6, 2026
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Note

Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported.

@github-actions github-actions Bot added the engine flutter/engine related. See also e: labels. label Nov 6, 2026
@auto-submit auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Nov 7, 2026
@auto-submit

auto-submit Bot commented Nov 7, 2026

Copy link
Copy Markdown
Contributor

autosubmit label was removed for flutter/flutter/196144, because - The status or check suite Dashboard Checks has failed. Please fix the issues identified (or deflake) before re-applying this label.

@engine-flutter-autoroll

Copy link
Copy Markdown
Contributor Author

Commit queue failed; closing this roll.

hubot pushed a commit to google/skia that referenced this pull request Nov 7, 2026
This reverts commit 9628428.

Reason for revert: breaks the Flutter roll
(flutter/flutter#196144). The web CanvasKit
test SkParagraph kitchensink in canvaskit_api_test.dart pins
LineMetrics.left == 2.5: its line starts with letterSpacing 5 and ends
with plain "!", so the line shift is now 0 instead of 2.5, as intended.
The test also has a golden (paragraph_kitchen_sink.png). Flutter will
first accept both values, then this change relands.

The revert had a conflict in SkParagraphTest.cpp with the next change
(SkParagraph_LigatureWithUnresolvedMark); only the test of the
reverted change is removed.

Bug: flutter/flutter#184815
Assisted-by: Claude Opus 5.5 (Medium)
Change-Id: I86d695b30f5daa9f945706c59bb5ddb4e9ce0369
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/1420816
Reviewed-by: Thomas Smith <[email protected]>
Commit-Queue: Julia Lavrova <[email protected]>
Reviewed-by: Brett Somocurcio <[email protected]>
ChandraChaan pushed a commit to ChandraChaan/flutter that referenced this pull request Nov 10, 2026
…tter#196148)

The SkParagraph kitchensink test in canvaskit_api_test.dart pins
LineMetrics.left to 2.5. Its line starts with letterSpacing 5 and ends
with an unspaced "!", and Skia shifted the whole line right by half the
first spacing, so the "!" ended 2.5 px past the line width. A Skia
change
for flutter#184815 caps the shift by
the half spacing of the visually last cluster, which is 0 here, and it
broke the Skia roll (flutter#196144).

Accept both 2.5 and 0 so the Skia change can reland. A follow-up after
the roll expects 0 only.

Assisted-by: Claude Opus 5.5 (Medium)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CICD Run CI/CD engine flutter/engine related. See also e: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants