Skip to content

[flutter_tools, flutter_test] Deprecate --experimental-faster-testing - #196123

Merged
auto-submit[bot] merged 4 commits into
flutter:masterfrom
bkonyi:remove-experimental-faster-testing
Nov 13, 2026
Merged

auto-submit[bot] merged 4 commits into
flutter:masterfrom
bkonyi:remove-experimental-faster-testing

Conversation

@bkonyi

@bkonyi bkonyi commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

Deprecates the unused --experimental-faster-testing flag (emitting a deprecation warning when passed) and removes FlutterTestRunner.runTestsBySpawningLightweightEngines from flutter_tools (along with its unused direct package:ffi dependency), while keeping the native FFI hooks in tester_main.cc intact. Also removes the defaultRouteNameTestValue = '/' initialization workaround from TestWidgetsFlutterBinding() and clears defaultRouteNameTestValue in TestWidgetsFlutterBinding.reset().

Closes #146603
Closes #161083
Closes #168657

Removes the unused `--experimental-faster-testing` flag and `FlutterTestRunner.runTestsBySpawningLightweightEngines` from `flutter_tools`, along with its unused direct `package:ffi` dependency.

Previously, `--experimental-faster-testing` generated monolithic Dart spawner entrypoints that imported all test suites into a single compilation unit and ran them via `Shell::Spawn` inside one `flutter_tester` process. Because `Shell::Spawn` shares a single UI/raster/platform task runner across spawned engines, suites executed on one thread while losing incremental compilation, compile-error isolation, VM service/coverage support, and `FlutterPlatform` integration. The native FFI hooks in `tester_main.cc` remain in place.

Also removes the `defaultRouteNameTestValue = '/'` initialization workaround added for `--experimental-faster-testing` in `TestWidgetsFlutterBinding()`, and updates `TestWidgetsFlutterBinding.reset()` to call `platformDispatcher.clearDefaultRouteNameTestValue()` so route overrides do not leak across tests.

Closes flutter#146603
Closes flutter#161083
Closes flutter#168657
@bkonyi bkonyi added the CICD Run CI/CD label Nov 6, 2026
@github-actions github-actions Bot added a: tests "flutter test", flutter_test, or one of our tests tool Affects the "flutter" command-line tool. See also t: labels. framework flutter/packages/flutter repository. See also f: labels. labels Nov 6, 2026
Re-adds `--experimental-faster-testing` as a deprecated verbose-only flag on `TestCommand` that logs a deprecation warning and runs standard test execution, so callers passing the flag do not fail argument parsing.
@bkonyi bkonyi changed the title [flutter_tools, flutter_test] Remove --experimental-faster-testing [flutter_tools, flutter_test] Deprecate --experimental-faster-testing Nov 6, 2026
@bkonyi
bkonyi marked this pull request as ready for review November 9, 2026 20:30
@bkonyi
bkonyi requested a review from chingjun November 9, 2026 20:30

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request deprecates the --experimental-faster-testing flag in Flutter tools, changing it to log a deprecation warning without executing any faster testing logic. The associated code for spawning lightweight engines, including several helper methods, unused imports, and the ffi dependency in pubspec.yaml, has been removed. Additionally, TestWidgetsFlutterBinding is updated to clear defaultRouteNameTestValue during reset() instead of setting it to '/' in the constructor, and corresponding tests have been updated. There are no review comments to address, and no further feedback is provided.

@bkonyi bkonyi added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 13, 2026
@auto-submit auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Nov 13, 2026
@auto-submit

auto-submit Bot commented Nov 13, 2026

Copy link
Copy Markdown
Contributor

autosubmit label was removed for flutter/flutter/196123, because - The status or check suite Dashboard Checks has failed. Please fix the issues identified (or deflake) before re-applying this label.

@bkonyi bkonyi added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 13, 2026
@auto-submit auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Nov 13, 2026
@auto-submit

auto-submit Bot commented Nov 13, 2026

Copy link
Copy Markdown
Contributor

autosubmit label was removed for flutter/flutter/196123, because - The status or check suite Presubmit has failed. Please fix the issues identified (or deflake) before re-applying this label.

@bkonyi bkonyi added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 13, 2026
@auto-submit
auto-submit Bot added this pull request to the merge queue Nov 13, 2026
Merged via the queue into flutter:master with commit d2196a6 Nov 13, 2026
25 of 26 checks passed
@flutter-dashboard flutter-dashboard Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Nov 13, 2026
auto-submit Bot pushed a commit to flutter/packages that referenced this pull request Nov 13, 2026
…13653)

Manual roll Flutter from 9c427b5d7b1c to 1b9585481095 (32 revisions)

Manual roll requested by [email protected]

flutter/flutter@9c427b5...1b95854

2026-11-13 [email protected] Roll pub packages (flutter/flutter#196541)
2026-11-13 [email protected] Do not route PRs for review without cla, convert to draft (flutter/flutter#196341)
2026-11-13 [email protected] Roll Skia from d87a6c04da74 to 11f46cfe8838 (13 revisions) (flutter/flutter#196533)
2026-11-13 [email protected] [flutter_tools, flutter_test] Deprecate --experimental-faster-testing (flutter/flutter#196123)
2026-11-13 [email protected] [flutter_tools] Handle RPCError in ScreenshotCommand.runSkia (flutter/flutter#196132)
2026-11-13 [email protected] Roll Dart SDK from a8b961fd48bb to c91e8b6674e2 (2 revisions) (flutter/flutter#196502)
2026-11-13 [email protected] Roll Skia from 0c5ce4960cef to d87a6c04da74 (12 revisions) (flutter/flutter#196497)
2026-11-13 [email protected] Don't call `skia_image()`  for raster-owned images in `DlImage::Equals` (flutter/flutter#196473)
2026-11-13 [email protected] [flutter_tools] Require FlutterCommandRunner DI fields and extract findCommandName (flutter/flutter#196331)
2026-11-13 [email protected] [web] Unify ui.Canvas behind a shared EngineCanvas frontend (flutter/flutter#196348)
2026-11-13 [email protected] Link to MediaQuery.displayFeaturesOf from DisplayFeatures (flutter/flutter#193728)
2026-11-13 [email protected] Removes reference to unnecessary ensureSemantics call in doc (flutter/flutter#195831)
2026-11-13 [email protected] [flutter_tools] Register trackWidgetCreation in AppleBuildOptionsBundle (flutter/flutter#196078)
2026-11-12 [email protected] [Android] Skip the HardwareBuffer defect fallback for platform views (flutter/flutter#193441)
2026-11-12 [email protected] Fix supports_decal check in framebuffer_blend.frag (flutter/flutter#196227)
2026-11-12 [email protected] [ios] Update the screen in didUpdateEffectiveGeometry (flutter/flutter#195508)
2026-11-12 [email protected] [flutter_tools] Add `Cache-Control` headers for web test assets (flutter/flutter#196414)
2026-11-12 [email protected] Roll Skia from 3b71ec08218f to 0c5ce4960cef (16 revisions) (flutter/flutter#196472)
2026-11-12 [email protected] [web] Render bounded ImageFilter.blur on wimp (flutter/flutter#196081)
2026-11-12 [email protected] Roll Dart SDK from 69567bd3c427 to a8b961fd48bb (2 revisions) (flutter/flutter#196464)
2026-11-12 [email protected] [engine] Release the Skia OpenGL resource context on shutdown (flutter/flutter#193592)
2026-11-12 [email protected] [web] Fix decoding of still AVIF images on Chrome (flutter/flutter#195958)
2026-11-12 [email protected] Gate SurfaceControl context setting on API 34+ (flutter/flutter#196394)
2026-11-12 [email protected] [flutter_tools] Only pass on a valid root tool in DASH__TOOL (flutter/flutter#196228)
2026-11-12 [email protected] Support GL_TEXTURE_EXTERNAL_OES embedder textures in Impeller (flutter/flutter#195857)
2026-11-12 [email protected] Stop building linux/wasm_release in local_engine_builds (flutter/flutter#196345)
2026-11-12 [email protected] Split flame out of Linux customer_testing (flutter/flutter#196347)
2026-11-12 Jiwon Lee [Windows] Fix Space input after Alt+Space with previous Microsoft IME (flutter/flutter#192105)
2026-11-12 [email protected] [flutter_tools] Add ToolExtensionException, exit() guard, graceful shutdown, and base modifiers (flutter/flutter#195908)
2026-11-12 [email protected] Roll Packages from 653628e to 14f9933 (9 revisions) (flutter/flutter#196450)
2026-11-12 [email protected] Roll Dart SDK from e5add7a25b32 to 69567bd3c427 (2 revisions) (flutter/flutter#196437)
2026-11-12 [email protected] Roll Skia from 9aa2513a4ac9 to 3b71ec08218f (1 revision) (flutter/flutter#196436)

If this roll has caused a breakage, revert this CL and set the roller
to dry run mode using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a: tests "flutter test", flutter_test, or one of our tests CICD Run CI/CD framework flutter/packages/flutter repository. See also f: labels. tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

2 participants